Skip to content

Conversation

@claudevdm
Copy link
Collaborator

This PR adds support for writing nanosecond-precision timestamps to BigQuery via the Storage Write API. BigQuery's TIMESTAMP type with precision 12 (picoseconds) can store timestamps with sub-microsecond precision.

Changes

1. Avro GenericRecord Support (AvroGenericRecordToStorageApiProto.java)

  • Detects timestamp-nanos logical type
  • Maps to BigQuery TIMESTAMP with timestampPrecision = 12
  • Converts Long (nanoseconds since epoch) → TimestampPicos proto message {seconds, picoseconds}
  • Properly handles nullable fields via UNION type propagation

2. Beam Row Support (BeamRowToStorageApiProto.java)

  • Detects Timestamp.NANOS logical type (precision = 9)
  • Maps to BigQuery TIMESTAMP with timestampPrecision = 12
  • Converts java.time.InstantTimestampPicos proto message {seconds, picoseconds}

3. BigQuery Avro Utils (BigQueryAvroUtils.java)

  • Sets timestampPrecision = 12 when reading timestamp-nanos fields

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the BigQuery Storage Write API integration by introducing comprehensive support for nanosecond-precision timestamps. It enables users to accurately store and retrieve time-series data with sub-microsecond granularity when using both Avro GenericRecords and Beam Rows, aligning with BigQuery's TIMESTAMP type capabilities. The changes involve updating schema mapping logic and data conversion mechanisms to correctly handle nanosecond values, ensuring data integrity and precision.

Highlights

  • Nanosecond Timestamp Support: Enabled writing nanosecond-precision timestamps to BigQuery via the Storage Write API.
  • Avro GenericRecord Handling: Implemented detection of timestamp-nanos logical type, mapping it to BigQuery TIMESTAMP with precision 12, and converting Long (nanoseconds since epoch) to TimestampPicos proto messages.
  • Beam Row Handling: Added support for Timestamp.NANOS logical type, mapping it to BigQuery TIMESTAMP with precision 12, and converting java.time.Instant to TimestampPicos proto messages.
  • Schema Definition Updates: Ensured that BigQuery schema generation correctly sets timestampPrecision = 12 for nanosecond timestamp fields in both Avro and Beam schemas.
  • Comprehensive Testing: Introduced new unit and integration tests to validate the correct serialization, deserialization, and end-to-end writing/reading of nanosecond timestamps for both Avro GenericRecords and Beam Rows.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claudevdm
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for nanosecond-precision timestamps when writing to BigQuery using the Storage Write API, for both Avro GenericRecords and Beam Rows. The changes are well-implemented and include corresponding tests. I've provided a few suggestions to improve code clarity, reduce duplication, and enhance maintainability by using constants for magic numbers and refactoring some logic.

@claudevdm claudevdm marked this pull request as ready for review January 6, 2026 17:24
@claudevdm
Copy link
Collaborator Author

R: @Abacn

@claudevdm
Copy link
Collaborator Author

R: @damccorm

@claudevdm
Copy link
Collaborator Author

R: @ahmedabu98

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm
Copy link
Contributor

damccorm commented Jan 6, 2026

/gemini review

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for nanosecond-precision timestamps for the BigQuery Storage Write API, for both Avro GenericRecords and Beam Rows. The changes are well-structured, covering schema conversion, data conversion, and comprehensive new tests. The logic for handling nanosecond timestamps, including negative timestamps, appears correct. I've made a few suggestions to improve code clarity and maintainability, mainly by replacing magic numbers with named constants and simplifying some arithmetic logic. Overall, this is a solid contribution.

@claudevdm claudevdm merged commit 4777bef into apache:master Jan 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants