Skip to content

Commit 58ef573

Browse files
committed
API: add resource type name for resource count response
Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>
1 parent 6062c47 commit 58ef573

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
// under the License.
1717
package org.apache.cloudstack.api.response;
1818

19+
import com.cloud.configuration.Resource;
1920
import com.google.gson.annotations.SerializedName;
2021

2122
import org.apache.cloudstack.api.ApiConstants;
@@ -49,6 +50,10 @@ public class ResourceCountResponse extends BaseResponse implements ControlledEnt
4950
@Param(description = "resource type. Values include 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11. See the resourceType parameter for more information on these values.")
5051
private String resourceType;
5152

53+
@SerializedName(ApiConstants.RESOURCE_TYPE_NAME)
54+
@Param(description = "resource type name. Values include user_vm, public_ip, volume, snapshot, template, project, network, vpc, cpu, memory, primary_storage, secondary_storage.")
55+
private String resourceTypeName;
56+
5257
@SerializedName("resourcecount")
5358
@Param(description = "resource count")
5459
private long resourceCount;
@@ -68,8 +73,9 @@ public void setDomainName(String domainName) {
6873
this.domainName = domainName;
6974
}
7075

71-
public void setResourceType(String resourceType) {
72-
this.resourceType = resourceType;
76+
public void setResourceType(Resource.ResourceType resourceType) {
77+
this.resourceType = Integer.valueOf(resourceType.getOrdinal()).toString();
78+
this.resourceTypeName = resourceType.getName();
7379
}
7480

7581
public void setResourceCount(Long resourceCount) {

api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
// under the License.
1717
package org.apache.cloudstack.api.response;
1818

19+
import com.cloud.configuration.Resource;
1920
import com.google.gson.annotations.SerializedName;
2021

2122
import org.apache.cloudstack.api.ApiConstants;
@@ -80,12 +81,9 @@ public void setDomainName(String domainName) {
8081
this.domainName = domainName;
8182
}
8283

83-
public void setResourceType(String resourceType) {
84-
this.resourceType = resourceType;
85-
}
86-
87-
public void setResourceTypeName(String resourceTypeName) {
88-
this.resourceTypeName = resourceTypeName;
84+
public void setResourceType(Resource.ResourceType resourceType) {
85+
this.resourceType = Integer.valueOf(resourceType.getOrdinal()).toString();
86+
this.resourceTypeName = resourceType.getName();
8987
}
9088

9189
public void setMax(Long max) {

server/src/com/cloud/api/ApiResponseHelper.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,7 @@ public ResourceLimitResponse createResourceLimitResponse(ResourceLimit limit) {
411411
populateAccount(resourceLimitResponse, limit.getOwnerId());
412412
populateDomain(resourceLimitResponse, accountTemp.getDomainId());
413413
}
414-
resourceLimitResponse.setResourceType(Integer.toString(limit.getType().getOrdinal()));
415-
resourceLimitResponse.setResourceTypeName(limit.getType().getName());
414+
resourceLimitResponse.setResourceType(limit.getType());
416415

417416
if ((limit.getType() == ResourceType.primary_storage || limit.getType() == ResourceType.secondary_storage) && limit.getMax() >= 0) {
418417
resourceLimitResponse.setMax((long)Math.ceil((double)limit.getMax() / ResourceType.bytesToGiB));
@@ -438,7 +437,7 @@ public ResourceCountResponse createResourceCountResponse(ResourceCount resourceC
438437
populateDomain(resourceCountResponse, resourceCount.getOwnerId());
439438
}
440439

441-
resourceCountResponse.setResourceType(Integer.toString(resourceCount.getType().getOrdinal()));
440+
resourceCountResponse.setResourceType(resourceCount.getType());
442441
resourceCountResponse.setResourceCount(resourceCount.getCount());
443442
resourceCountResponse.setObjectName("resourcecount");
444443
return resourceCountResponse;

0 commit comments

Comments
 (0)