template: Copying templates to all zones if type changed to system

Author: davidjumani

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

@@ -28,6 +28,7 @@
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import java.util.stream.Collectors;
 
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
@@ -844,16 +845,19 @@ public boolean copy(long userId, VMTemplateVO template, DataStore srcSecStore, D
             }
         }
         return true;
-
     }
 
     @Override
     @ActionEvent(eventType = EventTypes.EVENT_TEMPLATE_COPY, eventDescription = "copying template", async = true)
     public VirtualMachineTemplate copyTemplate(CopyTemplateCmd cmd) throws StorageUnavailableException, ResourceAllocationException {
         Long templateId = cmd.getId();
-        Long userId = CallContext.current().getCallingUserId();
         Long sourceZoneId = cmd.getSourceZoneId();
         List<Long> destZoneIds = cmd.getDestinationZoneIds();
+        return copyTemplate(templateId, sourceZoneId, destZoneIds);
+    }
+
+    private VirtualMachineTemplate copyTemplate(Long templateId, Long sourceZoneId, List<Long> destZoneIds) throws StorageUnavailableException, ResourceAllocationException {
+        Long userId = CallContext.current().getCallingUserId();
         Account caller = CallContext.current().getCallingAccount();
 
         // Verify parameters
@@ -2198,6 +2202,21 @@ private VMTemplateVO updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
             template.setDynamicallyScalable(isDynamicallyScalable);
         }
 
+        if (templateType != null && templateType == TemplateType.SYSTEM) {
+            s_logger.info("Copying template to all zones since it will be a system template");
+            List<DataCenterVO> zones = _dcDao.listEnabledZones();
+            if (zones != null) {
+                List<Long> zoneIds = zones.stream().map(zone -> zone.getId()).collect(Collectors.toList());
+                try {
+                    copyTemplate(id, null, zoneIds);
+                } catch (StorageUnavailableException e) {
+                    throw new CloudRuntimeException("Unable to copy template to other zones : ", e);
+                } catch (ResourceAllocationException e) {
+                    throw new CloudRuntimeException("Unable to copy template to other zones : ", e);
+                }
+            }
+        }
+
         if (isRoutingTemplate != null) {
             if (isRoutingTemplate) {
                 template.setTemplateType(TemplateType.ROUTING);