Fix syncVolumeToRootFolder method from recursing infinitely ending with StackOverFlowError

Dingane Hlaluku · Dingane Hlaluku · commit 842c88878ca7 · 2018-12-19T07:13:35.000+02:00
diff --git a/plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageLayoutHelper.java b/plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
@@ -143,7 +143,7 @@ public static String syncVolumeToVmDefaultFolder(DatacenterMO dcMo, String vmNam
     }
 
     public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName, String vmName) throws Exception {
-        syncVolumeToRootFolder(dcMo, ds, vmdkName, null);
+        syncVolumeToRootFolder(dcMo, ds, vmdkName, vmName, null);
     }
 
     public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName, String vmName, String excludeFolders) throws Exception {

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ public static String syncVolumeToVmDefaultFolder(DatacenterMO dcMo, String vmNam`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName, String vmName) throws Exception {`
`146`		`- syncVolumeToRootFolder(dcMo, ds, vmdkName, null);`
	`146`	`+ syncVolumeToRootFolder(dcMo, ds, vmdkName, vmName, null);`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`public static void syncVolumeToRootFolder(DatacenterMO dcMo, DatastoreMO ds, String vmdkName, String vmName, String excludeFolders) throws Exception {`