Skip to content

Commit 8ace272

Browse files
Set length for parameters that expect a list of domain ids. (#5763)
Currently, when updating a service offering there is a limitation of the number of domains the offering can be updated. Multiple domain ids lead to the following API error: Error: (HTTP 431, error code 9999) Unable to execute API command updateserviceoffering due to invalid value. Value greater than max allowed length 255 for param: domainIds"
1 parent d49f67c commit 8ace272

4 files changed

Lines changed: 8 additions & 4 deletions

File tree

api/src/main/java/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ public class UpdateNetworkOfferingCmd extends BaseCmd {
8686
@Parameter(name = ApiConstants.ZONE_ID,
8787
type = CommandType.STRING,
8888
description = "the ID of the containing zone(s) as comma separated string, all for all zones offerings",
89-
since = "4.13")
89+
since = "4.13",
90+
length = 4096)
9091
private String zoneIds;
9192

9293
/////////////////////////////////////////////////////

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ public class UpdateDiskOfferingCmd extends BaseCmd {
6969
@Parameter(name = ApiConstants.DOMAIN_ID,
7070
type = CommandType.STRING,
7171
description = "the ID of the containing domain(s) as comma separated string, public for public offerings",
72-
since = "4.13")
72+
since = "4.13",
73+
length = 4096)
7374
private String domainIds;
7475

7576
@Parameter(name = ApiConstants.ZONE_ID,

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ public class UpdateServiceOfferingCmd extends BaseCmd {
6464

6565
@Parameter(name = ApiConstants.DOMAIN_ID,
6666
type = CommandType.STRING,
67-
description = "the ID of the containing domain(s) as comma separated string, public for public offerings")
67+
description = "the ID of the containing domain(s) as comma separated string, public for public offerings",
68+
length = 4096)
6869
private String domainIds;
6970

7071
@Parameter(name = ApiConstants.ZONE_ID,

api/src/main/java/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ public class UpdateVPCOfferingCmd extends BaseAsyncCmd {
6060

6161
@Parameter(name = ApiConstants.DOMAIN_ID,
6262
type = CommandType.STRING,
63-
description = "the ID of the containing domain(s) as comma separated string, public for public offerings")
63+
description = "the ID of the containing domain(s) as comma separated string, public for public offerings",
64+
length = 4096)
6465
private String domainIds;
6566

6667
@Parameter(name = ApiConstants.ZONE_ID,

0 commit comments

Comments
 (0)