Skip to content

Commit 94a47ac

Browse files
VR: fix password server exception when no password is found (#9699)
see errors in /var/log/daemon.log below ``` Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: ---------------------------------------- Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: Exception occurred during processing of request from ('192.168.20.8', 51108) Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: Traceback (most recent call last): Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/usr/lib/python3.11/socketserver.py", line 691, in process_request_thread Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: self.finish_request(request, client_address) Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/usr/lib/python3.11/socketserver.py", line 361, in finish_request Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: self.RequestHandlerClass(request, client_address, self) Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/usr/lib/python3.11/socketserver.py", line 755, in __init__ Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: self.handle() Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/usr/lib/python3.11/http/server.py", line 432, in handle Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: self.handle_one_request() Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/usr/lib/python3.11/http/server.py", line 420, in handle_one_request Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: method() Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/opt/cloud/bin/passwd_server_ip.py", line 117, in do_GET Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: self.wfile.write('saved_password') Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: File "/usr/lib/python3.11/socketserver.py", line 834, in write Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: self._sock.sendall(b) Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: TypeError: a bytes-like object is required, not 'str' Sep 13 12:36:58 systemvm passwd_server_ip.py[2154]: ---------------------------------------- ```
1 parent 7d95952 commit 94a47ac

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

systemvm/debian/opt/cloud/bin/passwd_server_ip.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,19 +114,19 @@ def do_GET(self):
114114
if requestType == 'send_my_password':
115115
password = getPassword(clientAddress)
116116
if not password:
117-
self.wfile.write('saved_password')
117+
self.wfile.write('saved_password'.encode())
118118
syslog.syslog('serve_password: requested password not found for %s' % clientAddress)
119119
else:
120120
self.wfile.write(password.encode())
121121
syslog.syslog('serve_password: password sent to %s' % clientAddress)
122122
elif requestType == 'saved_password':
123123
removePassword(clientAddress)
124124
savePasswordFile()
125-
self.wfile.write('saved_password')
125+
self.wfile.write('saved_password'.encode())
126126
syslog.syslog('serve_password: saved_password ack received from %s' % clientAddress)
127127
else:
128128
self.send_response(400)
129-
self.wfile.write('bad_request')
129+
self.wfile.write('bad_request'.encode())
130130
syslog.syslog('serve_password: bad_request from IP %s' % clientAddress)
131131
return
132132

0 commit comments

Comments
 (0)