Skip to content

Commit da1a07b

Browse files
committed
fix test
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
1 parent 817e678 commit da1a07b

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

plugins/integrations/kubernetes-service/src/test/java/com/cloud/kubernetes/version/KubernetesVersionServiceTest.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,14 @@
3030
import org.apache.cloudstack.api.command.user.iso.DeleteIsoCmd;
3131
import org.apache.cloudstack.api.command.user.iso.RegisterIsoCmd;
3232
import org.apache.cloudstack.api.command.user.kubernetes.version.ListKubernetesSupportedVersionsCmd;
33+
import org.apache.cloudstack.api.response.KubernetesSupportedVersionResponse;
34+
import org.apache.cloudstack.api.response.ListResponse;
3335
import org.apache.cloudstack.context.CallContext;
3436
import org.apache.cloudstack.engine.subsystem.api.storage.ObjectInDataStoreStateMachine;
3537
import org.apache.cloudstack.framework.config.ConfigKey;
38+
import org.apache.commons.collections.CollectionUtils;
3639
import org.junit.After;
40+
import org.junit.Assert;
3741
import org.junit.Before;
3842
import org.junit.Test;
3943
import org.junit.runner.RunWith;
@@ -64,6 +68,7 @@
6468
import com.cloud.user.AccountVO;
6569
import com.cloud.user.User;
6670
import com.cloud.user.UserVO;
71+
import com.cloud.utils.Pair;
6772
import com.cloud.utils.component.ComponentContext;
6873
import com.cloud.utils.db.Filter;
6974
import com.cloud.utils.db.SearchBuilder;
@@ -140,8 +145,13 @@ public void listKubernetesSupportedVersionsTest() {
140145
when(versionVO.getSemanticVersion()).thenReturn(KubernetesVersionService.MIN_KUBERNETES_VERSION);
141146
versionVOs.add(versionVO);
142147
when(kubernetesSupportedVersionDao.findById(Mockito.anyLong())).thenReturn(versionVO);
143-
when(kubernetesSupportedVersionDao.search(Mockito.any(SearchCriteria.class), Mockito.any(Filter.class))).thenReturn(versionVOs);
144-
kubernetesVersionService.listKubernetesSupportedVersions(cmd);
148+
when(kubernetesSupportedVersionDao.searchAndCount(Mockito.any(SearchCriteria.class),
149+
Mockito.any(Filter.class))).thenReturn(new Pair<>(versionVOs, versionVOs.size()));
150+
ListResponse<KubernetesSupportedVersionResponse> versionsResponse =
151+
kubernetesVersionService.listKubernetesSupportedVersions(cmd);
152+
Assert.assertEquals(versionVOs.size(), versionsResponse.getCount().intValue());
153+
Assert.assertTrue(CollectionUtils.isNotEmpty(versionsResponse.getResponses()));
154+
Assert.assertEquals(versionVOs.size(), versionsResponse.getResponses().size());
145155
}
146156

147157
@Test(expected = InvalidParameterValueException.class)

0 commit comments

Comments
 (0)