The internal instance name is returned for non-root admin in listVirtualMachineMetrics API

[yadvr]

The internal instance name is returned for non-root admin in listVirtualMachineMetrics API response but not in the listVirtualMachines API response.

We need to check and fix to ensure we only return the internal instance-name for root-admins only.

Tested on the Primate QA server against 4.14.

ISSUE TYPE

• Bug Report

COMPONENT NAME

API

CLOUDSTACK VERSION

4.14 (tested), 4.13 (possibly)

[yadvr]

cc @davidjumani please pick this one as well, thanks.

[onitake]

I'm not sure if making the API asymmetric is the best idea. IMHO, the returned values should be the same for everybody. Why is the internal name returned in the first place?

[yadvr]

@onitake you're repeating the bug-report, sorry I didn't get your point?

[onitake]

Sorry @rhtyd , I didn't see that you were talking about two different API calls. My point wasn't about the asymmetry between listVirtualMachineMetrics and listVirtualMachines, but between root and non-root.
Wouldn't it be cleaner to return the same set of values for all types of users?

[yadvr]

Np @onitake - not really because root admin should be able to know more infrastructure specific information, for example the host where the VM is running on but not to the normal user. Because of this, we need to return information for root admin for many APIs, but not for users. The asymmetrical response is a feature.