Commit 63caf50
docs: tighten codec dispatch test docstrings
The previous docstrings claimed the tests verify "PythonLogicalCodec
delegates non-Python UDFs to the inner codec." That's
forward-looking — the codecs currently delegate every UDF
unconditionally, so the test would behave identically for Python and
non-Python UDFs.
Rewrite to describe what the test actually proves: the dispatch chain
`PyLogicalPlan.to_bytes -> session.logical_codec -> PythonLogicalCodec
-> FFI -> user impl` (and the physical mirror) forwards correctly,
observable via the user codec's atomic counter incrementing after one
encode pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent b2d77f4 commit 63caf50
2 files changed
Lines changed: 24 additions & 7 deletions
File tree
- examples/datafusion-ffi-example/python/tests
Lines changed: 14 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
47 | 58 | | |
48 | 59 | | |
49 | 60 | | |
| |||
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
48 | 54 | | |
49 | 55 | | |
50 | 56 | | |
| |||
0 commit comments