Addressing review comments

Author: MaheshGPai

tdigest/include/tdigest_impl.hpp

@@ -638,11 +638,11 @@ template <typename T, typename A>
 }
 
 template<typename T, typename A>
-tdigest<T, A>::const_iterator::const_iterator(const tdigest& tdigest_, const bool is_end):
-  centroids_()
+tdigest<T, A>::const_iterator::const_iterator(const tdigest<T, A>& tdigest_, const bool is_end):
+  centroids_(tdigest_.get_allocator())
 {
   // Create a copy of the tdigest to generate the centroids after processing the buffered values
-  tdigest tmp(tdigest_);
+  tdigest<T, A> tmp(tdigest_);
   tmp.compress();
   centroids_.insert(centroids_.end(), tmp.centroids_.begin(), tmp.centroids_.end());
 

tdigest/test/tdigest_test.cpp

@@ -460,11 +460,14 @@ TEST_CASE("iterate centroids", "[tdigest]") {
   }
 
   auto centroid_count = 0;
+  uint64_t total_weight = 0;
   for (const auto &centroid: td) {
     centroid_count++;
+    total_weight += centroid.second;
   }
   // Ensure that centroids are retrieved for a case where there is buffered values
   REQUIRE(centroid_count == 10);
+  REQUIRE(td.get_total_weight() == total_weight);
 }
 
 } /* namespace datasketches */