From c0ecd24f81847622bc9e003681ff17ab88219583 Mon Sep 17 00:00:00 2001 From: bd2019us Date: Sat, 13 Apr 2019 22:31:19 -0500 Subject: [PATCH] GERONIMO-6721 Use Objects.equals(String,String) to avoid possible NullPointerException --- .../apache/geronimo/console/webmanager/ConnectorPortlet.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/webmanager/ConnectorPortlet.java b/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/webmanager/ConnectorPortlet.java index 40b711cb70..c7764b2916 100644 --- a/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/webmanager/ConnectorPortlet.java +++ b/plugins/console/console-base-portlets/src/main/java/org/apache/geronimo/console/webmanager/ConnectorPortlet.java @@ -24,6 +24,8 @@ import java.util.Comparator; import java.util.HashMap; import java.util.List; +import java.util.Objects; + import javax.portlet.ActionRequest; import javax.portlet.ActionResponse; @@ -103,7 +105,7 @@ public void processAction(ActionRequest actionRequest, server = "unknown"; } actionResponse.setRenderParameter(PARM_SERVER, server); - if(mode.equals("new")) { + if(Objects.equals(mode, "new")) { // User selected to add a new connector, need to show criteria portlet actionResponse.setRenderParameter(PARM_MODE, "new"); String connectorType = actionRequest.getParameter(PARM_CONNECTOR_TYPE);