Bug Type (问题类型)
None
Before submit
Environment (环境信息)
Environment
| Item |
Detail |
| Module |
python-client |
| File |
hugegraph-python-client/src/tests/test_gremlin.py |
| Affected Lines |
L41–52 (setUpClass) |
Expected & Actual behavior (期望与实际表现)
Expected & Actual Behavior
Problem
The skip_gremlin_tests probe inside setUpClass (L41–52) silently skips all 6 Gremlin integration tests whenever the Gremlin endpoint returns a 404, times out, or raises a connection error.
This is a silent-skip anti-pattern: a future regression would surface in CI as 6 skipped rather than 6 failed, making it invisible to reviewers and breaking the reliability of the test suite.
Expected
Any connectivity or response failure during the probe should fail loudly — the same principle applied to the auth probe fix in #325.
Actual
The probe swallows 404 / timeout / connection error and marks the entire class as skipped via unittest.skip, hiding real failures behind a green (skipped) status.
Suggested Fix
Two equivalent options:
Option A — Drop the probe entirely
Remove skip_gremlin_tests and let the first test fail naturally if the endpoint is unavailable. This is the simplest fix and mirrors standard integration-test practice.
Option B — Convert the 404 branch to AssertionError
# Before (silent skip)
except (ConnectionError, Timeout, HTTPError):
raise unittest.SkipTest("Gremlin endpoint unavailable")
After (loud failure)
except (ConnectionError, Timeout, HTTPError) as e:
raise AssertionError(
f"Gremlin endpoint probe failed — endpoint may be down or misconfigured: {e}"
)
Either option ensures regressions surface as failures, not silent skips.
Related Issues
Labels
test python-client
Vertex/Edge example (问题点 / 边数据举例)
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
Bug Type (问题类型)
None
Before submit
Environment (环境信息)
Environment
Expected & Actual behavior (期望与实际表现)
Expected & Actual Behavior
Problem
The
skip_gremlin_testsprobe insidesetUpClass(L41–52) silently skips all 6 Gremlin integration tests whenever the Gremlin endpoint returns a404, times out, or raises a connection error.This is a silent-skip anti-pattern: a future regression would surface in CI as 6 skipped rather than 6 failed, making it invisible to reviewers and breaking the reliability of the test suite.
Expected
Any connectivity or response failure during the probe should fail loudly — the same principle applied to the auth probe fix in #325.
Actual
The probe swallows
404 / timeout / connection errorand marks the entire class as skipped viaunittest.skip, hiding real failures behind a green (skipped) status.Suggested Fix
Two equivalent options:
Option A — Drop the probe entirely
Remove
skip_gremlin_testsand let the first test fail naturally if the endpoint is unavailable. This is the simplest fix and mirrors standard integration-test practice.Option B — Convert the 404 branch to
AssertionErrorEither option ensures regressions surface as failures, not silent skips.
Related Issues
Labels
testpython-clientVertex/Edge example (问题点 / 边数据举例)
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)