fix(sdk): allow hostnames in server address configuration (#2923)

Author: felixfaisal

core/common/src/lib.rs

@@ -127,6 +127,7 @@ pub use utils::crypto::*;
 pub use utils::duration::{IggyDuration, SEC_IN_MICRO};
 pub use utils::expiry::IggyExpiry;
 pub use utils::hash::*;
+pub use utils::net::validate_server_address;
 pub use utils::personal_access_token_expiry::PersonalAccessTokenExpiry;
 pub use utils::random_id;
 pub use utils::serde_secret;

core/common/src/types/configuration/tcp_config/tcp_client_config_builder.rs

@@ -15,8 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-use crate::{AutoLogin, IggyDuration, IggyError, TcpClientConfig};
-use std::net::SocketAddr;
+use crate::{AutoLogin, IggyDuration, IggyError, TcpClientConfig, validate_server_address};
 
 /// Builder for the TCP client configuration.
 /// Allows configuring the TCP client with custom settings or using defaults:
@@ -103,13 +102,9 @@ impl TcpClientConfigBuilder {
     }
 
     /// Builds the TCP client configuration.
-    pub fn build(self) -> Result<TcpClientConfig, IggyError> {
-        let addr = self.config.server_address.trim();
-
-        if addr.parse::<SocketAddr>().is_err() {
-            let (ip, port) = addr.rsplit_once(':').unwrap_or((addr, ""));
-            return Err(IggyError::InvalidIpAddress(ip.to_owned(), port.to_owned()));
-        }
+    pub fn build(mut self) -> Result<TcpClientConfig, IggyError> {
+        self.config.server_address = self.config.server_address.trim().to_string();
+        validate_server_address(&self.config.server_address)?;
 
         Ok(self.config)
     }
@@ -148,12 +143,16 @@ mod tests {
     }
 
     #[test]
-    fn invalid_ip_should_fail() {
+    fn valid_dns_name_should_succeed() {
+        let builder = builder_with_address("localhost:8080");
+        assert!(builder.build().is_ok());
+    }
+
+    #[test]
+    fn unresolvable_hostname_should_succeed() {
+        // Format is valid; DNS resolution is not attempted
         let builder = builder_with_address("invalid.ip:8080");
-        assert!(matches!(
-            builder.build(),
-            Err(IggyError::InvalidIpAddress(_, _))
-        ));
+        assert!(builder.build().is_ok());
     }
 
     #[test]
@@ -182,4 +181,10 @@ mod tests {
             Err(IggyError::InvalidIpAddress(_, _))
         ));
     }
+
+    #[test]
+    fn docker_compose_service_name_should_succeed() {
+        let builder = builder_with_address("iggy-server:8090");
+        assert!(builder.build().is_ok());
+    }
 }

core/common/src/types/configuration/websocket_config/websocket_client_config_builder.rs

@@ -16,8 +16,7 @@
  * under the License.
  */
 
-use crate::{AutoLogin, IggyDuration, IggyError, WebSocketClientConfig};
-use std::net::SocketAddr;
+use crate::{AutoLogin, IggyDuration, IggyError, WebSocketClientConfig, validate_server_address};
 
 /// Builder for the WebSocket client configuration.
 /// Allows configuring the WebSocket client with custom settings or using defaults:
@@ -139,19 +138,9 @@ impl WebSocketClientConfigBuilder {
     }
 
     /// Builds the WebSocket client configuration.
-    pub fn build(self) -> Result<WebSocketClientConfig, IggyError> {
-        let addr = self.config.server_address.trim();
-
-        // Check if it's a valid socket address or host:port format
-        if addr.parse::<SocketAddr>().is_err() {
-            let (host, port) = addr.rsplit_once(':').unwrap_or((addr, ""));
-            if port.is_empty() || port.parse::<u16>().is_err() {
-                return Err(IggyError::InvalidIpAddress(
-                    host.to_owned(),
-                    port.to_owned(),
-                ));
-            }
-        }
+    pub fn build(mut self) -> Result<WebSocketClientConfig, IggyError> {
+        self.config.server_address = self.config.server_address.trim().to_string();
+        validate_server_address(&self.config.server_address)?;
 
         Ok(self.config)
     }

core/common/src/utils/mod.rs

@@ -23,6 +23,7 @@ pub(crate) mod crypto;
 pub(crate) mod duration;
 pub(crate) mod expiry;
 pub(crate) mod hash;
+pub(crate) mod net;
 pub(crate) mod personal_access_token_expiry;
 pub mod random_id;
 pub mod serde_secret;