From acf04f06486a3ad8b76d889ff758e323f84a18b3 Mon Sep 17 00:00:00 2001 From: ChineseTom Date: Mon, 30 Mar 2026 16:42:16 +0800 Subject: [PATCH] reduce copy --- .../rocketmq/broker/config/v1/RocksDBConfigManager.java | 2 +- .../apache/rocketmq/broker/processor/AckMessageProcessor.java | 2 +- .../rocketmq/broker/processor/AdminBrokerProcessor.java | 4 ++-- .../broker/processor/ChangeInvisibleTimeProcessor.java | 4 ++-- .../apache/rocketmq/broker/processor/PopMessageProcessor.java | 2 +- .../proxy/service/sysmessage/AbstractSystemMessageSyncer.java | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConfigManager.java b/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConfigManager.java index e68cd20a9d2..3cc9adc5e65 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConfigManager.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConfigManager.java @@ -162,7 +162,7 @@ public void delete(final byte[] keyBytes) throws Exception { public void updateKvDataVersion() throws Exception { kvDataVersion.nextVersion(); this.configRocksDBStorage.put(versionCF, KV_DATA_VERSION_KEY, KV_DATA_VERSION_KEY.length, - JSON.toJSONString(kvDataVersion).getBytes(StandardCharsets.UTF_8)); + JSON.toJSONBytes(kvDataVersion, StandardCharsets.UTF_8)); } public DataVersion getKvDataVersion() { diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java index 34a790efca7..f46d63a3cd1 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java @@ -290,7 +290,7 @@ private void appendAck(final AckMessageRequestHeader requestHeader, final BatchA MessageExtBrokerInner msgInner = new MessageExtBrokerInner(); msgInner.setTopic(reviveTopic); - msgInner.setBody(JSON.toJSONString(ackMsg).getBytes(StandardCharsets.UTF_8)); + msgInner.setBody(JSON.toJSONBytes(ackMsg, StandardCharsets.UTF_8)); msgInner.setQueueId(rqId); if (ackMsg instanceof BatchAckMsg) { msgInner.setTags(PopAckConstants.BATCH_ACK_TAG); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java index 73aaa69e74a..0e8996b550b 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java @@ -3195,7 +3195,7 @@ private RemotingCommand getUser(ChannelHandlerContext ctx, response.setCode(ResponseCode.SUCCESS); if (user != null) { UserInfo userInfo = UserConverter.convertUser(user); - response.setBody(JSON.toJSONString(userInfo).getBytes(StandardCharsets.UTF_8)); + response.setBody(JSON.toJSONBytes(userInfo, StandardCharsets.UTF_8)); } }) .exceptionally(ex -> { @@ -3218,7 +3218,7 @@ private RemotingCommand listUser(ChannelHandlerContext ctx, response.setCode(ResponseCode.SUCCESS); if (CollectionUtils.isNotEmpty(users)) { List userInfos = UserConverter.convertUsers(users); - response.setBody(JSON.toJSONString(userInfos).getBytes(StandardCharsets.UTF_8)); + response.setBody(JSON.toJSONBytes(userInfos, StandardCharsets.UTF_8)); } }) .exceptionally(ex -> { diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/ChangeInvisibleTimeProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/ChangeInvisibleTimeProcessor.java index a8b01ceed27..7afba8ed753 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/ChangeInvisibleTimeProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/ChangeInvisibleTimeProcessor.java @@ -282,7 +282,7 @@ private CompletableFuture ackOrigin(final ChangeInvisibleTimeRequestHea } msgInner.setTopic(reviveTopic); - msgInner.setBody(JSON.toJSONString(ackMsg).getBytes(StandardCharsets.UTF_8)); + msgInner.setBody(JSON.toJSONBytes(ackMsg, StandardCharsets.UTF_8)); msgInner.setQueueId(rqId); msgInner.setTags(PopAckConstants.ACK_TAG); msgInner.setBornTimestamp(System.currentTimeMillis()); @@ -326,7 +326,7 @@ private CompletableFuture appendCheckPointThenAckOrigin( ck.setBrokerName(ExtraInfoUtil.getBrokerName(extraInfo)); ck.setSuspend(requestHeader.isSuspend()); - msgInner.setBody(JSON.toJSONString(ck).getBytes(StandardCharsets.UTF_8)); + msgInner.setBody(JSON.toJSONBytes(ck, StandardCharsets.UTF_8)); msgInner.setQueueId(reviveQid); msgInner.setTags(PopAckConstants.CK_TAG); msgInner.setBornTimestamp(System.currentTimeMillis()); diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java index c32e1b5ae23..e3555971d8f 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java @@ -942,7 +942,7 @@ public MessageExtBrokerInner buildCkMsg(final PopCheckPoint ck, final int revive MessageExtBrokerInner msgInner = new MessageExtBrokerInner(); msgInner.setTopic(reviveTopic); - msgInner.setBody(JSON.toJSONString(ck).getBytes(StandardCharsets.UTF_8)); + msgInner.setBody(JSON.toJSONBytes(ck, StandardCharsets.UTF_8)); msgInner.setQueueId(reviveQid); msgInner.setTags(PopAckConstants.CK_TAG); msgInner.setBornTimestamp(System.currentTimeMillis()); diff --git a/proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/AbstractSystemMessageSyncer.java b/proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/AbstractSystemMessageSyncer.java index 05eb6726188..1fb04459503 100644 --- a/proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/AbstractSystemMessageSyncer.java +++ b/proxy/src/main/java/org/apache/rocketmq/proxy/service/sysmessage/AbstractSystemMessageSyncer.java @@ -96,7 +96,7 @@ protected void sendSystemMessage(Object data) { try { Message message = new Message( targetTopic, - JSON.toJSONString(data).getBytes(StandardCharsets.UTF_8) + JSON.toJSONBytes(data, StandardCharsets.UTF_8) ); AddressableMessageQueue messageQueue = this.topicRouteService.getAllMessageQueueView(ProxyContext.createForInner(this.getClass()), targetTopic)