fixed some sonar issues

Author: a-brandt

src/main/java/com/arangodb/entity/BaseEntity.java

@@ -74,7 +74,7 @@ public abstract class BaseEntity implements Serializable {
 	 * @return boolean
 	 */
 	public boolean isNotModified() {
-		return statusCode == 304; // HttpStatus.SC_NOT_MODIFIED;
+		return statusCode == 304;
 	}
 
 	/**
@@ -86,15 +86,6 @@ public boolean isUnauthorized() {
 		return statusCode == 401;
 	}
 
-	// /**
-	// * If the requested resource has not been modified it returns true
-	// *
-	// * @return boolean
-	// */
-	// public boolean isNotFound() {
-	// return statusCode == 404;
-	// }
-
 	/**
 	 * If this is the response of a batch request it returns true
 	 *

src/main/java/com/arangodb/entity/CollectionType.java

@@ -23,29 +23,36 @@
  *
  */
 public enum CollectionType {
-  /**
-   * Document collection type
-   */
-  DOCUMENT(2),
-
-  /**
-   * Edge collection type, used for graphs
-   */
-  EDGE(3);
-  private final int type;
-  private CollectionType(int type) {
-    this.type = type;
-  }
-  public int getType() {
-    return type;
-  }
-  public static CollectionType valueOf(int type) {
-    switch (type) {
-    case 2:
-      return DOCUMENT;
-    case 3:
-      return EDGE;
-    }
-    return null;
-  }
+	/**
+	 * Document collection type
+	 */
+	DOCUMENT(2),
+
+	/**
+	 * Edge collection type, used for graphs
+	 */
+	EDGE(3);
+
+	private final int type;
+
+	private CollectionType(int type) {
+		this.type = type;
+	}
+
+	public int getType() {
+		return type;
+	}
+
+	public static CollectionType valueOf(int type) {
+		CollectionType result = null;
+		
+		if (type == 2) {
+			result = DOCUMENT;
+		}
+		else if (type == 3) {
+			result = EDGE;
+		}
+
+		return result;
+	}
 }

src/main/java/com/arangodb/entity/JobsEntity.java

@@ -30,9 +30,8 @@ public class JobsEntity extends BaseEntity {
 	/**
 	 * The enumeration containing the job state
 	 */
-	public static enum JobState {
-		DONE,
-		PENDING;
+	public enum JobState {
+		DONE, PENDING;
 		public java.lang.String getName() {
 			if (this == DONE) {
 				return "done";
@@ -44,7 +43,11 @@ public java.lang.String getName() {
 		}
 	}
 
-	List<String> jobs;
+	private List<String> jobs;
+
+	public JobsEntity(List<String> jobs) {
+		this.jobs = jobs;
+	}
 
 	public List<String> getJobs() {
 		return jobs;
@@ -53,8 +56,4 @@ public List<String> getJobs() {
 	public void setJobs(List<String> jobs) {
 		this.jobs = jobs;
 	}
-
-	public JobsEntity(List<String> jobs) {
-		this.jobs = jobs;
-	}
 }