Skip to content

Code improvement suggestions #12

@susant123

Description

@susant123

I was going through few Java files. Might be you can consider below suggestions.

  • Backend.java
    1. Final static variable command can be renamed to COMMAND
    2. Few variables like gson can be declared final I suppose as it is initialized in the constructor
    3. How about using an if instead of switch as it has only one case (in postJson())
  • Activator.java
    1. Do we need to write default constructor?
  • POCDocument.java
    1. How about changing private GUID to guid as its a not a constant?
  • POCDocumentPartitioner.java
    1. How about changing types to TYPES as it is final static?
  • POCDocumentProvider.java
    1. How about changing mode to MODE as it is final static?
  • POCTokenScanner.java
    1. Do we really need the default constructor?

I am not sure if code formatter is being used. If not will request to add a standard code formatter.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions