From 723699aea6a43016715d2601585acb8ae5e5b1bf Mon Sep 17 00:00:00 2001 From: Joseph Cloutier Date: Sat, 17 Feb 2024 16:44:58 -0500 Subject: [PATCH] Remove redundant `delete` operations. Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/delete#description , the operator does not actually free memory, but simply removes a reference to that memory, allowing it to be garbage collected later. This is similar to the `= null` assignments that happen on the very next lines. --- lib/managers/StreamingAudioChannel.ts | 4 +--- lib/parsers/WaveAudioParser.ts | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/managers/StreamingAudioChannel.ts b/lib/managers/StreamingAudioChannel.ts index 6595007b..67436d38 100644 --- a/lib/managers/StreamingAudioChannel.ts +++ b/lib/managers/StreamingAudioChannel.ts @@ -252,13 +252,11 @@ export class StreamingAudioChannel extends BaseAudioChannel implements IAudioCha this._sourceBuffer.removeEventListener('updateend', this._updateEndDelegate); this._mediaSource.removeSourceBuffer(this._sourceBuffer); - delete this._sourceBuffer; this._sourceBuffer = null; } this._mediaSource.removeEventListener('sourceopen', this._sourceOpenDelegate); URL.revokeObjectURL(this._urlString); - delete this._mediaSource; this._mediaSource = null; } -} \ No newline at end of file +} diff --git a/lib/parsers/WaveAudioParser.ts b/lib/parsers/WaveAudioParser.ts index 6373742a..7406407d 100644 --- a/lib/parsers/WaveAudioParser.ts +++ b/lib/parsers/WaveAudioParser.ts @@ -33,8 +33,6 @@ export class WaveAudioParser extends ParserBase { } protected startParsing(frameLimit: number): void { - //clear content - delete this._content; this._content = null; super.startParsing(frameLimit); @@ -83,4 +81,4 @@ export class WaveAudioParser extends ParserBase { return null; } -} \ No newline at end of file +}