Skip to content

On PR merge

On PR merge #70

Triggered via workflow run August 29, 2025 04:57
@sliedigsliedig
completed 1e96286
Status Failure
Total duration 19s
Artifacts

on_merged_pr.yml

on: workflow_run
get_pr_details  /  export_pr_details
5s
get_pr_details / export_pr_details
release_label_on_merge
4s
release_label_on_merge
Fit to window
Zoom out
Zoom in

Annotations

1 error
release_label_on_merge
Unable to find related issue for PR number 48. Body details: "## Summary\r\n\r\n## **1. unicorn_approvals/ApprovalsService/pom.xml**\r\n• **Added test environment variable**: CONTRACT_STATUS_TABLE=test-table for testing\r\n• **Added Maven Surefire dependency**: Added JUnit4 support with version 3.5.3\r\n\r\n## **2. ContractStatusChangedHandlerFunction.java**\r\n• **Enhanced logging**: Added comprehensive logging throughout the function\r\n• **Added error handling**: Wrapped the main logic in try-catch with proper error logging\r\n• **Environment validation**: Added check to ensure CONTRACT_STATUS_TABLE is set\r\n• **Debug information**: Added logging for table name, events received, and DynamoDB operations\r\n\r\n## **3. unicorn_web/Common/src/main/java/dao/Property.java**\r\n• **Fixed partition key generation**: Changed from lowercase conversion of entire string to lowercase conversion of individual components\r\n\r\n## **4. unicorn_web/Data/property_data.json**\r\n• **Fixed partition key format**: Updated all PK values from lowercase property# to uppercase PROPERTY#\r\n• **Consistency fix**: Ensures test data matches the new partition key format\r\n\r\n## **5. PublicationApprovedEventHandler.java**\r\n• **Enhanced logging**: Added detailed logging for property updates and key generation\r\n• **Fixed partition key**: Changed from search# prefix to PROPERTY# prefix\r\n• **Debug output**: Added logging for partition key, sort key, and existing property data\r\n\r\n## **6. RequestApprovalFunction.java** (Major Refactoring)\r\n• **Changed from API Gateway to SQS**: Completely refactored from handling API Gateway events to SQS events\r\n• **Removed HTTP response logic**: Eliminated all API Gateway response creation methods\r\n• **Added batch processing**: Now processes multiple SQS messages in a single invocation\r\n• **Enhanced error handling**: Individual message failures don't stop processing of other messages\r\n• **Improved logging**: Added comprehensive logging throughout the processing pipeline\r\n• **Fixed partition key**: Changed from search# to PROPERTY# prefix\r\n• **Added environment logging**: Logs environment variables for debugging\r\n\r\n## **7. PropertySearchFunction.java**\r\n• **Fixed partition key**: Changed from search# to PROPERTY# prefix for consistency\r\n• **Added debug logging**: Added logging for partition and sort keys\r\n\r\n## **Overall Impact**\r\nThis commit primarily fixes a partition key inconsistency across the application where some components were using search# while others expected PROPERTY#. \r\nThe changes ensure all components use the consistent PROPERTY# prefix, along with improved error handling and logging throughout the system. The major \r\narchitectural change is converting the approval request function from API Gateway-triggered to SQS-triggered for better scalability and reliability.\r\n\r\n## Checklist\r\n\r\nPlease leave checklist items unchecked if they do not apply to your change.\r\n\r\n* [x] I have performed a self-review of this change\r\n* [x] Changes have been tested\r\n* [x] Changes are documented\r\n* [ ] PR title follows [conventional commit semantics](https://github.com/aws-samples/aws-serverless-developer-experience-workshop-java/blob/develop/.github/semantic.yml)\r\n\r\n## Acknowledgment\r\n\r\nBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.\r\n\r\n**Disclaimer**: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.\r\n"