Skip to content

Await cancelation of sending_task in _stream_stream to prevent writing on closed stream. #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachary-walravens wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Await cancelation of sending_task in _stream_stream to prevent writing on closed stream. #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions betterproto2/src/betterproto2/grpclib/grpclib_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,14 @@ async def _stream_stream(
try:
async for response in stream:
yield response
except:
finally:
sending_task.cancel()
raise
try:
await sending_task
except asyncio.CancelledError:
pass
if not stream._end_done:
await stream.end()

@staticmethod
async def _send_messages(stream, messages: MessageSource):
Expand Down