Get Transfer: return real object, not a map (#10)

* Get Transfer: return real object, not a map

* change return value to Optional<Transfer>

* remove commented code

Author: kushal256

bitgo-java-api/src/main/java/com/bitso/bitgo/v2/BitGoClient.java

@@ -1,6 +1,7 @@
 package com.bitso.bitgo.v2;
 
 import com.bitso.bitgo.v2.entity.SendCoinsResponse;
+import com.bitso.bitgo.v2.entity.Transfer;
 import com.bitso.bitgo.v2.entity.Wallet;
 import com.bitso.bitgo.v2.entity.WalletTransferResponse;
 
@@ -66,11 +67,11 @@ Optional<SendCoinsResponse> sendMany(String coin, String walletId, String wallet
      *
      * @param coin
      * @param walletId
-     * @param walletTransferId
+     * @param txid
      * @return
      * @throws IOException
      */
-    Optional<Map<String, Object>> getWalletTransferId(String coin, String walletId, String walletTransferId) throws IOException;
+    Optional<Transfer> getWalletTransferId(String coin, String walletId, String txid) throws IOException;
 
     /**
      * See https://www.bitgo.com/api/v2/?shell#get-wallet-transfer-by-sequence-id

bitgo-java-api/src/main/java/com/bitso/bitgo/v2/BitGoClientImpl.java

@@ -4,6 +4,7 @@
 import com.bitso.bitgo.util.SerializationUtil;
 import com.bitso.bitgo.v2.entity.ListWalletResponse;
 import com.bitso.bitgo.v2.entity.SendCoinsResponse;
+import com.bitso.bitgo.v2.entity.Transfer;
 import com.bitso.bitgo.v2.entity.Wallet;
 import com.bitso.bitgo.v2.entity.WalletTransferResponse;
 import com.fasterxml.jackson.core.type.TypeReference;
@@ -217,11 +218,10 @@ public Optional<Map<String, Object>> getCurrentUserProfile() throws IOException
     }
 
     @Override
-    public Optional<Map<String, Object>> getWalletTransferId(String coin, String walletId, String walletTransferId) throws IOException {
-        String url = baseUrl + GET_WALLET_TRANSFER_URL.replace("$COIN", coin).replace("$WALLET", walletId).replace("$TRANSFER", walletTransferId);
+    public Optional<Transfer> getWalletTransferId(String coin, String walletId, String txid) throws IOException {
+        String url = baseUrl + GET_WALLET_TRANSFER_URL.replace("$COIN", coin).replace("$WALLET", walletId).replace("$TRANSFER", txid);
         HttpURLConnection conn = httpGet(url);
-        Map<String, Object> resp = SerializationUtil.mapper.readValue(conn.getInputStream(), new TypeReference<Map<String, Object>>() {
-        });
+        Transfer resp = SerializationUtil.mapper.readValue(conn.getInputStream(), Transfer.class);
         log.trace("getWalletTransferId response: {}", resp);
         return Optional.of(resp);
     }
@@ -261,6 +261,8 @@ public WalletTransferResponse listWalletTransfers(String coin, String walletId,
         return resp;
     }
 
+
+
     @Override
     public int unlock(String otp, Long durationSecs) throws IOException {
         String url = baseUrl + UNLOCK_URL;

bitgo-java-api/src/test/java/com/bitso/bitgo/util/TestClientV2.java

@@ -3,6 +3,7 @@
 import com.bitso.bitgo.v2.BitGoClient;
 import com.bitso.bitgo.v2.BitGoClientImpl;
 import com.bitso.bitgo.v2.entity.SendCoinsResponse;
+import com.bitso.bitgo.v2.entity.Transfer;
 import com.bitso.bitgo.v2.entity.Wallet;
 import com.bitso.bitgo.v2.entity.WalletTransferResponse;
 import lombok.extern.slf4j.Slf4j;
@@ -134,7 +135,12 @@ public void listWalletTransfers() throws IOException {
 //            resp.getTransfers().remove(0);
 //        }
         System.out.println("resp json = " + SerializationUtil.mapper.writeValueAsString(resp));
+    }
 
-
+    @Test
+    public void getWalletTransfers() throws IOException {
+        final Optional<Transfer> resp = client.getWalletTransferId(COIN, WALLET_ID, "cdaa330f5717556d873506ee5bb283b3703f9b2a73899577ce3530ae2c75e0ea");
+        System.out.println("resp = " + resp.get());
+        System.out.println("resp json = " + SerializationUtil.mapper.writeValueAsString(resp.get()));
     }
 }