Fixed argument value bleed into the next empty argument (#19)

* Fixed bleeding value of the command argument into the next empty valued argument

Author: nfedyk

psCommandService.js

@@ -304,7 +304,7 @@ PSCommandService.prototype._generateCommand = function(commandConfig, argument2V
 
                         var passedArgValue = passedArgValues[i];
 
-                        var valueToSet;
+                        var valueToSet = "";
 
                         if (passedArgValue && passedArgValue != 'undefined') {
                             valueToSet = passedArgValue;

test/unit.js

@@ -84,6 +84,29 @@ const commandRegistry = {
       type: "text",
     },
   },
+  setContent: {
+    command: "Set-Content {{{arguments}}}",
+    arguments: {
+      'Path': {},
+      'Value': {},
+      'Filter': {},
+    },
+  },
+  getContent: {
+    command: "Get-Content {{{arguments}}}",
+    arguments: {
+      'Path': {},
+    },
+    return: {
+      type: "text",
+    },
+  },
+  removeItem: {
+    command: "Remove-Item {{{arguments}}}",
+    arguments: {
+      'Path': {},
+    },
+  },
 };
 
 
@@ -580,4 +603,53 @@ describe("test PSCommandService w/ o365CommandRegistry", function () {
       throw e;
     }
   });
+  it("Should test value bleeding", async function () {
+    this.timeout(10000);
+    const statefulProcessCommandProxy = new StatefulProcessCommandProxy({
+      name: "Powershell pool",
+      max: 1,
+      min: 1,
+      idleTimeoutMS: 30000,
+
+      logFunction: logFunction,
+      processCommand: "pwsh",
+      processArgs: ["-Command", "-"],
+      processRetainMaxCmdHistory: 30,
+      processCwd: null,
+      processEnvMap: null,
+      processUid: null,
+      processGid: null,
+      initCommands: initCommands,
+      validateFunction: (processProxy) => processProxy.isValid(),
+    });
+
+    const psCommandService = new PSCommandService(
+      statefulProcessCommandProxy,
+      commandRegistry,
+      myLogFunction
+    );
+    try {
+      const newResult = await psCommandService.execute("setContent", {
+        Path: "./test.txt",
+        Value: "Test",
+        Filter: ""
+      });
+      assert.equal(newResult.command.trim(), "Set-Content -Path './test.txt' -Value 'Test'");
+      assert.equal(newResult.stderr, "");
+      const getResult = await psCommandService.execute("getContent", {
+        Path: "./test.txt",
+      });
+      assert.equal(getResult.stderr, "");
+      assert.equal(getResult.stdout, "Test");
+    } catch (e) {
+      assert.fail(e);
+    } finally {
+      await psCommandService.execute("removeItem", {
+        Path: "./test.txt",
+       });    
+      setTimeout(() => {
+        statefulProcessCommandProxy.shutdown();
+      }, 5000);
+    }
+  });
 });