-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathconstraint_test.go
More file actions
600 lines (524 loc) · 12.1 KB
/
constraint_test.go
File metadata and controls
600 lines (524 loc) · 12.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
package api_test
import (
"errors"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/bjaus/api"
)
func TestValidateConstraints_minLength(t *testing.T) {
t.Parallel()
type req struct {
Name string `json:"name" minLength:"3"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"too short": {
input: req{Name: "ab"},
wantErr: true,
},
"exact minimum": {
input: req{Name: "abc"},
wantErr: false,
},
"longer than minimum": {
input: req{Name: "abcdef"},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "name", ve[0].Field)
assert.Contains(t, ve[0].Message, "at least 3 characters")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_maxLength(t *testing.T) {
t.Parallel()
type req struct {
Name string `json:"name" maxLength:"5"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"too long": {
input: req{Name: "abcdef"},
wantErr: true,
},
"exact maximum": {
input: req{Name: "abcde"},
wantErr: false,
},
"shorter than maximum": {
input: req{Name: "abc"},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "name", ve[0].Field)
assert.Contains(t, ve[0].Message, "at most 5 characters")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_minimum(t *testing.T) {
t.Parallel()
type req struct {
Age int `json:"age" minimum:"18"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"below minimum": {
input: req{Age: 10},
wantErr: true,
},
"at minimum": {
input: req{Age: 18},
wantErr: false,
},
"above minimum": {
input: req{Age: 25},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "age", ve[0].Field)
assert.Contains(t, ve[0].Message, "at least 18")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_maximum(t *testing.T) {
t.Parallel()
type req struct {
Score float64 `json:"score" maximum:"100"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"above maximum": {
input: req{Score: 150},
wantErr: true,
},
"at maximum": {
input: req{Score: 100},
wantErr: false,
},
"below maximum": {
input: req{Score: 50},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "score", ve[0].Field)
assert.Contains(t, ve[0].Message, "at most 100")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_pattern(t *testing.T) {
t.Parallel()
type req struct {
Email string `json:"email" pattern:"^[a-z]+@[a-z]+\\.[a-z]+$"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"does not match pattern": {
input: req{Email: "not-an-email"},
wantErr: true,
},
"matches pattern": {
input: req{Email: "user@example.com"},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "email", ve[0].Field)
assert.Contains(t, ve[0].Message, "must match pattern")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_enum(t *testing.T) {
t.Parallel()
type req struct {
Status string `json:"status" enum:"active,inactive,pending"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"invalid enum value": {
input: req{Status: "deleted"},
wantErr: true,
},
"valid enum active": {
input: req{Status: "active"},
wantErr: false,
},
"valid enum pending": {
input: req{Status: "pending"},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "status", ve[0].Field)
assert.Contains(t, ve[0].Message, "must be one of")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_minItems(t *testing.T) {
t.Parallel()
type req struct {
Tags []string `json:"tags" minItems:"2"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"too few items": {
input: req{Tags: []string{"one"}},
wantErr: true,
},
"exact minimum items": {
input: req{Tags: []string{"one", "two"}},
wantErr: false,
},
"more than minimum items": {
input: req{Tags: []string{"one", "two", "three"}},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "tags", ve[0].Field)
assert.Contains(t, ve[0].Message, "at least 2 items")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_maxItems(t *testing.T) {
t.Parallel()
type req struct {
Tags []string `json:"tags" maxItems:"3"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"too many items": {
input: req{Tags: []string{"a", "b", "c", "d"}},
wantErr: true,
},
"exact maximum items": {
input: req{Tags: []string{"a", "b", "c"}},
wantErr: false,
},
"fewer than maximum items": {
input: req{Tags: []string{"a"}},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "tags", ve[0].Field)
assert.Contains(t, ve[0].Message, "at most 3 items")
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_exhaustive_collects_all(t *testing.T) {
t.Parallel()
type req struct {
Name string `json:"name" minLength:"3" maxLength:"10"`
Age int `json:"age" minimum:"18" maximum:"120"`
Tags []string `json:"tags" minItems:"1"`
Role string `json:"role" enum:"admin,user"`
}
input := req{
Name: "a", // violates minLength
Age: 5, // violates minimum
Tags: []string{}, // violates minItems
Role: "superadmin", // violates enum
}
err := api.ValidateConstraints(input)
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 4)
fields := make(map[string]bool)
for _, e := range ve {
fields[e.Field] = true
}
assert.True(t, fields["name"])
assert.True(t, fields["age"])
assert.True(t, fields["tags"])
assert.True(t, fields["role"])
}
func TestValidateConstraints_valid_data_passes(t *testing.T) {
t.Parallel()
type req struct {
Name string `json:"name" minLength:"2" maxLength:"50"`
Age int `json:"age" minimum:"0" maximum:"200"`
Email string `json:"email" pattern:"^.+@.+$"`
Role string `json:"role" enum:"admin,user,guest"`
Tags []string `json:"tags" minItems:"1" maxItems:"10"`
}
input := req{
Name: "Alice",
Age: 30,
Email: "alice@example.com",
Role: "admin",
Tags: []string{"go", "api"},
}
err := api.ValidateConstraints(input)
require.NoError(t, err)
}
func TestValidateConstraints_non_struct_returns_nil(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints("not a struct")
require.NoError(t, err)
}
func TestValidateConstraints_pointer_to_struct(t *testing.T) {
t.Parallel()
type req struct {
Name string `json:"name" minLength:"5"`
}
input := &req{Name: "ab"}
err := api.ValidateConstraints(input)
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Len(t, ve, 1)
assert.Equal(t, "name", ve[0].Field)
}
func TestValidateConstraints_uint_minimum(t *testing.T) {
t.Parallel()
type req struct {
Count uint `json:"count" minimum:"5"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"below minimum": {
input: req{Count: 2},
wantErr: true,
},
"at minimum": {
input: req{Count: 5},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_float64_maximum(t *testing.T) {
t.Parallel()
type req struct {
Price float64 `json:"price" maximum:"99.99"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"above maximum": {
input: req{Price: 100.00},
wantErr: true,
},
"below maximum": {
input: req{Price: 50.00},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_skips_RawRequest(t *testing.T) {
t.Parallel()
type req struct {
api.RawRequest
Name string `json:"name" minLength:"3"`
}
input := req{Name: "abcde"}
err := api.ValidateConstraints(input)
require.NoError(t, err)
}
func TestValidateConstraints_nested_struct(t *testing.T) {
t.Parallel()
type Address struct {
City string `json:"city" minLength:"2"`
}
type req struct {
Address Address `json:"address"`
}
tests := map[string]struct {
input req
wantErr bool
}{
"nested violation": {
input: req{Address: Address{City: "a"}},
wantErr: true,
},
"nested valid": {
input: req{Address: Address{City: "NYC"}},
wantErr: false,
},
}
for name, tc := range tests {
t.Run(name, func(t *testing.T) {
t.Parallel()
err := api.ValidateConstraints(tc.input)
if tc.wantErr {
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Equal(t, "address.city", ve[0].Field)
} else {
require.NoError(t, err)
}
})
}
}
func TestValidateConstraints_body_field_recursion(t *testing.T) {
t.Parallel()
type req struct {
ID string `path:"id"`
Body struct {
Name string `json:"name" minLength:"3"`
}
}
input := req{ID: "abc", Body: struct {
Name string `json:"name" minLength:"3"`
}{Name: "ab"}}
err := api.ValidateConstraints(input)
require.Error(t, err)
var ve api.ValidationErrors
require.True(t, errors.As(err, &ve))
assert.Equal(t, "body.name", ve[0].Field)
}
func TestValidateConstraints_json_dash_skipped(t *testing.T) {
t.Parallel()
type req struct {
Skipped string `json:"-" minLength:"100"`
Name string `json:"name"`
}
input := req{Skipped: "short", Name: "valid"}
err := api.ValidateConstraints(input)
require.NoError(t, err)
}
func TestValidateConstraints_unexported_field_skipped(t *testing.T) {
t.Parallel()
type withUnexported struct {
hidden string `minLength:"100"` //nolint:unused
Name string `json:"name"`
}
input := withUnexported{Name: "valid"}
err := api.ValidateConstraints(input)
require.NoError(t, err)
}