Skip to content

Use JSON ingestion as schema definition extension#1205

Open
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extension-modulesfrom
joshuaw/json-ingestion-default-extension
Open

Use JSON ingestion as schema definition extension#1205
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extension-modulesfrom
joshuaw/json-ingestion-default-extension

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 20, 2026

Why

Complete the extraction by loading JSON ingestion through the schema-definition extension API and removing the duplicated core JSON Schema implementation.

What

  • Wire ElasticGraph::JSONIngestion::SchemaDefinition::APIExtension explicitly into app, template, doctest, and spec-helper schema definition setup
  • Move JSON Schema artifact/results behavior out of core schema_definition
  • Remove JSON Schema field/type/index logic from core classes now provided by the extension
  • Keep JSON schema version enforcement configured through schema.enforce_json_schema_version false

Risk Assessment

Medium to high — this is the behavior-transfer layer, but it sits after the move/namespace/add-extension PRs so the remaining diff is mostly deletion and wiring.

References

  • Stacked on Add JSON ingestion schema extension modules #1204.
  • Local lint, type check, spellcheck, targeted specs, schema artifact dump/check, and documentation coverage passed.
  • Full local script/quick_build could not run because Docker and docker-compose are not installed, so no local datastore can be booted; GitHub CI should cover that environment.

@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from f9fb615 to edc42c3 Compare May 20, 2026 20:03
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch 2 times, most recently from 024c4ef to d8c3c70 Compare May 20, 2026 20:15
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from edc42c3 to 62013f0 Compare May 20, 2026 20:15
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from d8c3c70 to b78686f Compare May 21, 2026 02:49
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch 2 times, most recently from 1eec3a6 to f13769d Compare May 21, 2026 13:43
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from b78686f to 0b3844f Compare May 21, 2026 13:43
@jwils jwils marked this pull request as ready for review May 22, 2026 18:24
@jwils jwils force-pushed the joshuaw/json-ingestion-default-extension branch from f13769d to ee7fe58 Compare May 22, 2026 22:41
@jwils jwils force-pushed the joshuaw/json-ingestion-extension-modules branch from 0b3844f to 65f9a60 Compare May 22, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant