fix: expand tool calls by default when Response Style is set to Detailed#8268
Closed
octo-patch wants to merge 1 commit intoaaif-goose:mainfrom
Closed
Conversation
aaif-goose#8213) When responseStyle is 'detailed', the outer ToolCallExpandable now starts expanded, and tool result views also start expanded. Previously, the outer expandable always started collapsed (unless progress was rendering), and ToolResultView always started collapsed regardless of responseStyle.
DOsinga
approved these changes
Apr 3, 2026
Collaborator
DOsinga
left a comment
There was a problem hiding this comment.
Clean, minimal fix — correctly wires the existing isExpandToolDetails variable into the two places that were ignoring it. LGTM.
One thing before this can merge: the DCO check is failing. Please amend your commit to include a Signed-off-by line, e.g.:
git commit --amend --signoff
git push --force
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8213
Problem
When Response Styles is set to Detailed in Settings → Chat, tool calls still appear collapsed by default in the desktop GUI. Restarting the app does not change the behavior, even though
responseStyleis confirmed asdetailedin settings.Solution
Two changes to
ui/desktop/src/components/ToolCallWithResponse.tsx:The outer
ToolCallExpandablewas usingisStartExpanded={isRenderingProgress}, which only expands when progress is actively rendering. Changed toisStartExpanded={isRenderingProgress || isExpandToolDetails}so tool calls start expanded whenresponseStyle === 'detailed'.ToolResultViewwas always rendered withisStartExpanded={false}regardless of response style. Changed toisStartExpanded={isExpandToolDetails}so tool output is also expanded in Detailed mode.The
isExpandToolDetailsvariable was already correctly computingtruefor'detailed'style andfalsefor'concise'— it just wasn't being used for the outer expandable and tool result views.Testing