Skip to content

fix: expand tool calls by default when Response Style is set to Detailed#8268

Closed
octo-patch wants to merge 1 commit intoaaif-goose:mainfrom
octo-patch:fix/issue-8213-tool-calls-collapsed-in-detailed-mode
Closed

fix: expand tool calls by default when Response Style is set to Detailed#8268
octo-patch wants to merge 1 commit intoaaif-goose:mainfrom
octo-patch:fix/issue-8213-tool-calls-collapsed-in-detailed-mode

Conversation

@octo-patch
Copy link
Copy Markdown
Contributor

Fixes #8213

Problem

When Response Styles is set to Detailed in Settings → Chat, tool calls still appear collapsed by default in the desktop GUI. Restarting the app does not change the behavior, even though responseStyle is confirmed as detailed in settings.

Solution

Two changes to ui/desktop/src/components/ToolCallWithResponse.tsx:

  1. The outer ToolCallExpandable was using isStartExpanded={isRenderingProgress}, which only expands when progress is actively rendering. Changed to isStartExpanded={isRenderingProgress || isExpandToolDetails} so tool calls start expanded when responseStyle === 'detailed'.

  2. ToolResultView was always rendered with isStartExpanded={false} regardless of response style. Changed to isStartExpanded={isExpandToolDetails} so tool output is also expanded in Detailed mode.

The isExpandToolDetails variable was already correctly computing true for 'detailed' style and false for 'concise' — it just wasn't being used for the outer expandable and tool result views.

Testing

  • Set Response Styles to Detailed in Settings → Chat
  • Send a message that triggers tool calls
  • Tool calls and their results should now start expanded
  • Switch to Concise — tool calls should start collapsed

 aaif-goose#8213)

When responseStyle is 'detailed', the outer ToolCallExpandable now starts
expanded, and tool result views also start expanded. Previously, the
outer expandable always started collapsed (unless progress was rendering),
and ToolResultView always started collapsed regardless of responseStyle.
Copy link
Copy Markdown
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal fix — correctly wires the existing isExpandToolDetails variable into the two places that were ignoring it. LGTM.

One thing before this can merge: the DCO check is failing. Please amend your commit to include a Signed-off-by line, e.g.:

git commit --amend --signoff
git push --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop tool calls stay collapsed when Response Styles is set to Detailed

3 participants