Tracker: code-quality cleanup

[0xdevcollins]

Code-quality items from internal review

Each subitem is small. Group into a single PR or several small PRs.

Magic numbers → named constants

const BPS_SCALE: u32 = 10_000;
const FIRST_PLACE_REP_POINTS: u32 = 100;
const SECOND_PLACE_REP_POINTS: u32 = 50;
const PARTICIPATION_REP_POINTS: u32 = 25;
const SECONDS_PER_DAY: u64 = 86_400;
const TRACK_ID_PER_HACKATHON_CAP: u32 = 1_000;

Inconsistent TTL extensions

Some functions extend TTL after storage writes, others don't. Apply uniformly. Consider a helper macro or wrap storage writes.

Add get_version() query

Returns a constant string (e.g., "hackathon_registry/0.4.0"). Indexers and frontends need to know which version they're talking to. Bump on every breaking change.

Missing events

Add and emit:

• JudgeAdded { hackathon_id, judge }
• JudgeRemoved { hackathon_id, judge }
• HackathonStatusChanged { hackathon_id, old: HackathonStatus, new: HackathonStatus }
• SubmissionDisqualified { hackathon_id, team_lead }
• DeadlineExtended { hackathon_id, field, old, new } (paired with #extension issue)

Rename submission_count → registration_count

The field tracks registrations, not submitted projects. Confusing for indexers and integrators. Plan as storage migration.

Reentrancy discipline: CEI pattern uniformly

Refactor older fns (cancel_hackathon, distribute_track_prizes) to set state changes BEFORE cross-contract calls. Audit every existing fn for this.

Inline doc comments

Functions are self-explanatory by name but pre/post conditions and invariants are undocumented. Add /// doc comments to each public fn with: auth required, state precondition, side effects, error cases.

[coderabbitai]

🔗 Related PRs

#1 - Fix/reduce build size [merged]
#9 - fix: Handle community vote rejection and expiry in check_vote_threshold [closed]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[Escelit]

I'd like to tackle these code-quality items as a single PR or two small PRs. I have experience with Solidity/Starknet contract hardening — including CEI refactoring, event emission, storage migrations, and doc standards. My approach: convert magic numbers to named constants, add get_version(), uniformly fix TTL extensions and reentrancy patterns across all functions, emit all missing events (JudgeAdded, JudgeRemoved, HackathonStatusChanged, SubmissionDisqualified, DeadlineExtended), rename submission_count → registration_count with a safe migration, and add /// doc comments to every public function covering auth, preconditions, side effects, and error cases. Ready to deliver clean, auditable code quickly.

[amankoli09]

Hey! I’d like to take this on.

I can handle the contract quality improvements by consolidating magic numbers into constants, standardizing TTL extension behavior, adding missing events and version queries, and improving documentation consistency across public functions. I’ll also review older flows for consistent CEI/reentrancy discipline and carefully handle the registration_count migration to avoid breaking behavior.

I’ll keep the changes modular, well-tested, and easy to review.

Happy to proceed once assigned.

[godamongstmen897]

Can you please assign me this issue to fix