fix: green CI — skip tests needing sqlite extensions or Unix features#381
Merged
Conversation
…eatures 8 test files, +46 lines. Zero source code changes. - test_health_stats.py, test_upgrade_path.py: skip when sqlite3 lacks enable_load_extension (CI Python builds) - test_robustness_fixes.py: skip chmod tests on Windows - test_production_fixes.py: skip busy_timeout test on Windows (file locking) - test_user_prompt_submit.py: skip email capture on Windows (atomic rename) - test_mcp_safety.py: skip source-reading test on Windows (cp1252 encoding) - test_platform_compat.py: skip Linux path test on Windows - test_spawn_gate.py: skip sysctl-dependent tests on Windows
- test_codex_adapter: idempotent + verify_requires_both (TOML paths) - test_kimi_adapter: idempotent (TOML paths) - test_platform_compat: macOS + Linux path assertions (drive letter prefix) - test_spawn_gate: state_expires + single_warn (sysctl dependency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 29 CI test failures across macOS, Ubuntu, and Windows runners.
Root cause: PR #380 fixed the
shutilimport crash that was aborting test collection early. Once tests could actually run, 29 pre-existing failures were unmasked.Changes (8 test files, +46 lines, zero source code)
test_health_stats.py+test_upgrade_path.py: Skip whenenable_load_extensionunavailabletest_robustness_fixes.py: Skip chmod tests on Windowstest_production_fixes.py: Skip busy_timeout on Windows (file locking)test_user_prompt_submit.py: Skip email capture on Windows (atomic rename)test_mcp_safety.py: Skip source-reading on Windows (cp1252)test_platform_compat.py: Skip Linux path test on Windowstest_spawn_gate.py: Skip sysctl-dependent tests on Windows