Remove chat protocol e2e target (#423)

Author: blove

.github/workflows/ci.yml

@@ -253,45 +253,6 @@ jobs:
           path: examples/chat/angular/e2e/test-results/
           retention-days: 7
 
-  examples-chat-protocol-e2e:
-    name: examples/chat — protocol e2e
-    needs: ci-scope
-    if: github.event_name == 'push' || needs.ci-scope.outputs.examples_chat == 'true'
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6.0.2
-      - uses: actions/setup-node@v6.3.0
-        with:
-          node-version: 22
-          cache: npm
-      - name: Install uv
-        uses: astral-sh/setup-uv@v8.0.0
-        with:
-          python-version: '3.12'
-      - run: npm ci
-      - working-directory: examples/chat/python
-        run: uv sync
-      - name: Start LangGraph dev server
-        working-directory: examples/chat/python
-        run: uv run langgraph dev --no-browser &
-        env:
-          OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
-          LANGSMITH_API_KEY: ${{ secrets.LANGSMITH_API_KEY }}
-          LANGSMITH_TRACING: 'true'
-          LANGSMITH_PROJECT: examples-chat-protocol-e2e-ci
-      - name: Wait for server to be ready
-        run: |
-          echo "Waiting for LangGraph server..."
-          for i in {1..30}; do
-            curl -sf http://localhost:2024/ok && echo "Server ready" && break
-            echo "Attempt $i/30..."
-            sleep 2
-          done
-          curl -sf http://localhost:2024/ok || (echo "Server failed to start after 60s" && exit 1)
-      - run: npx nx e2e examples-chat-protocol-e2e --skip-nx-cache
-        env:
-          LANGGRAPH_URL: http://localhost:2024
-
   cockpit-e2e:
     name: Cockpit — e2e
     needs: ci-scope
@@ -374,7 +335,6 @@ jobs:
         cockpit-deploy-smoke,
         examples-chat-smoke,
         examples-chat-e2e,
-        examples-chat-protocol-e2e,
         cockpit-e2e,
         website-e2e,
       ]
@@ -544,7 +504,7 @@ jobs:
 
   demo-deploy:
     name: Canonical demo → Vercel
-    needs: [examples-chat-smoke, examples-chat-e2e, examples-chat-protocol-e2e]
+    needs: [examples-chat-smoke, examples-chat-e2e]
     runs-on: ubuntu-latest
     if: ${{ always() && !cancelled() && github.ref == 'refs/heads/main' && github.event_name == 'push' }}
     steps:
@@ -558,10 +518,6 @@ jobs:
             echo "::error::examples/chat — e2e finished with ${{ needs.examples-chat-e2e.result }}; refusing to deploy the canonical demo."
             exit 1
           fi
-          if [ "${{ needs.examples-chat-protocol-e2e.result }}" != "success" ]; then
-            echo "::error::examples/chat — protocol e2e finished with ${{ needs.examples-chat-protocol-e2e.result }}; refusing to deploy the canonical demo."
-            exit 1
-          fi
       - uses: actions/checkout@v6.0.2
       - uses: actions/setup-node@v6.3.0
         with:

AGENTS.md

@@ -38,7 +38,7 @@ This file is for agents working in this repository. It is contributor-facing, no
 
 - `libs/langgraph`: main Angular library (`@ngaf/langgraph`).
 - `apps/website`: docs and marketing site.
-- `examples/chat/e2e`: protocol end-to-end coverage for the canonical chat example.
+- `examples/chat/angular/e2e`: browser end-to-end coverage for the canonical chat example.
 
 ## Working in This Repo
 

examples/chat/e2e/project.json

@@ -221,7 +221,6 @@ function applyFallbackPathScope(scope, changedFile) {
 function isGlobalCiFile(changedFile) {
   return (
     changedFile === '.github/workflows/ci.yml' ||
-    changedFile === '.github/workflows/e2e.yml' ||
     changedFile === 'package.json' ||
     changedFile === 'package-lock.json' ||
     changedFile === 'nx.json' ||

examples/chat/e2e/src/.gitkeep

@@ -52,14 +52,6 @@ const projects = [
     tags: [],
     targets: { build: {} },
   },
-  {
-    name: 'examples-chat-protocol-e2e',
-    root: 'examples/chat/e2e',
-    sourceRoot: 'examples/chat/e2e/src',
-    projectType: 'application',
-    tags: [],
-    targets: { e2e: {} },
-  },
 ];
 
 const workspace = {
@@ -122,18 +114,6 @@ test('global CI config changes keep full PR coverage', () => {
   assert.deepEqual(Object.values(scope), Object.values(scope).map(() => true));
 });
 
-test('standalone E2E workflow changes keep full PR coverage', () => {
-  const scope = classifyChangedFiles(['.github/workflows/e2e.yml'], workspace);
-
-  assert.deepEqual(Object.values(scope), Object.values(scope).map(() => true));
-});
-
-test('examples chat protocol e2e changes drive examples chat scope', () => {
-  const scope = classifyChangedFiles(['examples/chat/e2e/src/protocol.e2e.spec.ts'], workspace);
-
-  assert.equal(scope.examples_chat, true);
-});
-
 test('unowned docs changes do not trigger heavy CI jobs', () => {
   const scope = classifyChangedFiles(['docs/notes.md'], workspace);
 

examples/chat/e2e/src/protocol.e2e.spec.ts

@@ -15,14 +15,6 @@ describe('CI workflow', () => {
     );
   }
 
-  async function readDemoDeployJob() {
-    const workflow = await readWorkflow();
-    return workflow.slice(
-      workflow.indexOf('  demo-deploy:'),
-      workflow.indexOf('  production-smoke:')
-    );
-  }
-
   async function readProductionSmokeJob() {
     const workflow = await readWorkflow();
     return workflow.slice(
@@ -70,19 +62,4 @@ describe('CI workflow', () => {
     );
   });
 
-  it('runs examples chat protocol e2e before deploying the canonical demo', async () => {
-    const workflow = await readWorkflow();
-    const demoDeployJob = await readDemoDeployJob();
-
-    assert.match(workflow, /examples-chat-protocol-e2e:/);
-    assert.match(workflow, /npx nx e2e examples-chat-protocol-e2e --skip-nx-cache/);
-    assert.match(
-      demoDeployJob,
-      /needs:\s*\[examples-chat-smoke,\s*examples-chat-e2e,\s*examples-chat-protocol-e2e\]/
-    );
-    assert.match(
-      demoDeployJob,
-      /examples\/chat — protocol e2e finished with \$\{\{ needs\.examples-chat-protocol-e2e\.result \}\}/
-    );
-  });
 });