From e6bb48db2be9ce1fc1d36df09390adfeb0307a87 Mon Sep 17 00:00:00 2001 From: Brian Love Date: Tue, 19 May 2026 10:11:27 -0700 Subject: [PATCH] fix(c-a2ui): seed booking form origin/dest from prompt to ensure happy path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The welcome chips ("I want to fly LAX to JFK", "I want to fly SFO to SEA") trigger build_form, but on a fresh first turn the form's data_model carries blank defaults — and the LLM occasionally extracts the wrong values from the prompt (commonly sets both origin AND dest to LAX, which finds zero flights because the in-memory _FLIGHTS dataset has no same-airport routes). Add a deterministic regex pre-pass: `_seed_airports_from_messages` walks the message history for the most recent human prompt and extracts an (origin, dest) airport pair when the prompt explicitly names one ("LAX to JFK" / "lax → jfk" / "SFO -> SEA"). build_form uses those values to seed the form's data_model whenever there's no prior bookingSubmit context to draw from. The LLM still authors the spec but the field defaults are now correct. Guard rails: - Only matches IATA codes that appear in AIRPORT_CODES — never seeds an airport the form's dropdown can't render - Same-origin/dest pairs (LAX → LAX) are skipped (no flights match) - Only inspects human-role messages; action-message JSON and AI surfaces are filtered out - Prior-context path is unchanged: a Modify-search after a real submit still prefills from the submitted values, not the original prompt Verified end-to-end via real-LLM smoke: HumanMessage('I want to fly LAX to JFK') → form data_model = {origin: LAX, dest: JFK, ...} → bookingSubmit with LAX/JFK → results surface contains UA123 (the LAX→JFK flight in _FLIGHTS) Plus 11 unit cases for the seed helper: chip prompts, arrow notation, case-insensitive, same-airport guard, unknown airports, AI-message filter, action-JSON filter, most-recent-wins. Co-Authored-By: Claude Opus 4.7 (1M context) --- cockpit/chat/a2ui/python/src/graph.py | 54 +++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/cockpit/chat/a2ui/python/src/graph.py b/cockpit/chat/a2ui/python/src/graph.py index 01e5ecfc8..7842f402a 100644 --- a/cockpit/chat/a2ui/python/src/graph.py +++ b/cockpit/chat/a2ui/python/src/graph.py @@ -18,6 +18,7 @@ import json import logging +import re from typing import Any, Literal from langchain_core.messages import AIMessage, HumanMessage, SystemMessage @@ -388,6 +389,17 @@ async def build_form(state: MessagesState) -> dict: """ prior = _extract_prior_submit_context(state["messages"]) defaults = _form_defaults_from_prior(prior) + # If there's no prior bookingSubmit (true first turn), try to seed + # origin/dest from the most recent human prompt — e.g. the welcome chip + # "I want to fly LAX to JFK" should land on a form where Origin=LAX and + # Destination=JFK are already selected. Without this seed, the LLM is + # told to use the blank `data_model` verbatim and the user lands on a + # form whose default values find no flights (Origin=Destination=LAX is + # a common failure we've seen). Prior-context path skips this seed + # because it already carries the user's last-known values. + if not prior: + seed = _seed_airports_from_messages(state["messages"]) + defaults.update(seed) system_prompt = _BUILD_FORM_SYSTEM_TMPL.replace( "__DATA_MODEL_DEFAULTS__", json.dumps(defaults) ) @@ -655,6 +667,48 @@ def _is_flight_select_event(content: str) -> bool: ) +# Match " to " / " -> " / " → " +# where both are 3-letter IATA codes from AIRPORT_CODES. Anchored to word +# boundaries so we don't false-match "BOSTON" or arbitrary capitals. +_AIRPORT_CODES_RE = "|".join(re.escape(code) for code in AIRPORT_CODES) +_AIRPORT_PAIR_PATTERN = re.compile( + rf"\b({_AIRPORT_CODES_RE})\b\s*(?:to|->|→|-)\s*\b({_AIRPORT_CODES_RE})\b", + re.IGNORECASE, +) + + +def _seed_airports_from_messages(messages: list[Any]) -> dict[str, str]: + """Extract an (origin, dest) airport pair from the most recent human + message. Used by build_form on a fresh first turn to pre-fill the form + when the user's prompt explicitly mentions a route (e.g. the welcome + chip "I want to fly LAX to JFK"). + + Returns {"origin": , "dest": } on a hit; {} when no + recognized pair appears. Both codes must be in AIRPORT_CODES; we + never seed an airport the form's dropdown can't render.""" + for msg in reversed(messages): + # Only inspect human messages — AI surfaces and action JSON shouldn't + # be parsed for seed values. + if getattr(msg, "type", None) != "human": + continue + content = getattr(msg, "content", None) + if not isinstance(content, str): + continue + # Action messages also flow through as human-role; their content + # is JSON. Cheap filter: real prompts don't start with '{'. + if content.lstrip().startswith("{"): + continue + match = _AIRPORT_PAIR_PATTERN.search(content) + if match: + origin = match.group(1).upper() + dest = match.group(2).upper() + if origin == dest: + # Same-airport "route" can't possibly find flights; skip. + continue + return {"origin": origin, "dest": dest} + return {} + + def _extract_prior_submit_context(messages: list[Any]) -> dict[str, Any]: """Walk back, find the most recent bookingSubmit A2UI action message; return its unwrapped context dict (origin/dest/date/passengers/fare_class).