Issue executing example

[didos36]

Hello,

As a beginner with Xtext LSP integration, i'm currently to play with this example, and I'm hitting some strange issues.

1. For instance, after lauching the demo in vscode, and editing a file named b.mydsl with this content:
   `package foo {

   entity Bar {

   op test() : String {
   ""
   }
   }

}`

i'm getting this error message:
"The type Bar is already defined in b.mydsl."

Here is a trace I'm getting from LSP protocol if I'm not wrong.

[Trace - 15:43:47] Received notification 'textDocument/publishDiagnostics'. Params: { "uri": "file:///xxxxxx/git/xbase-languageserver-example/demo/src/b.mydsl", "diagnostics": [ { "range": { "start": { "line": 2, "character": 11 }, "end": { "line": 2, "character": 14 } }, "severity": 1, "code": "org.eclipse.xtext.xbase.validation.IssueCodes.duplicate_type", "message": "The type Bar is already defined in b.mydsl." } ] }

2. When i'm editing package name, generation happened after each hitting keyboard, and as a result I'm getting a directory tree corresponding to each intermediate package name, I mean, to enter a package name like 'name1', I will get a folder named as 'n' then 'na' then 'nam','name', and finally 'name1"

Do you have any clue that can help me?

[cdietrich]

2. you can disable the generator by binding a IGenerator that does nothing
3. i assume the validation needs to be adopted for that (see UniqueClassNameValidator)

will have a look at both points when i have time. (likely next week)

[cdietrich]

see https://github.com/cdietrich/xbase-languageserver-example/tree/cd_issue1 for unique validation fix

[didos36]

Thanks a lot! That was quite fast.

I've checkout cd_issue1 branch, did a gradle clean startCode, but I'm still getting same error:

[Trace - 07:11:33] Received notification 'textDocument/publishDiagnostics'. Params: { "uri": "file:///c%3A/Users/xxxxx/git/xbase-languageserver-example/demo/src/test2.mydsl", "diagnostics": [ { "range": { "start": { "line": 2, "character": 11 }, "end": { "line": 2, "character": 22 } }, "severity": 1, "code": "org.eclipse.xtext.xbase.validation.IssueCodes.duplicate_type", "message": "The type SuperEntity is already defined in test2.mydsl." } ] }

At the begining, I got some error related to duplicate type definition, like SuperEntity is already defined in SuperEntity.java file, but those one disappeared after installer Java extension in vscode. Your fix seems related to this error if I'm correct.

In addition, it seems quite unstable, for instance, sometime if I'm update Entity Name, nothing

[cdietrich]

Are you sure you really rebuilt everything on the new branch?

Did you debug the validator. This could be an encoding issue too.

Unfortunately I don’t have a windows machine to debug myself for the next few days

First I saw the same issue but after my fix it works but I am not sure if my fix works on windows

[didos36]

Hello,

Yes I'm sure I've built everything on branch 'cd_issue1' with a gradle clean startCode.

Just to be sure we are talking about the same error, the error message is : "message": "The type SuperEntity is already defined in test2.mydsl." so related to test2.mydsl file extension not java extension.

[cdietrich]

As I said: this needs to be debugged . Maybe you can change the validation to print both complete uris in the message

[cdietrich]

could be eclipse-archived/xtext-core#528
can you please test with 2.14.0-SNAPSHOT (should be in the sonatype oss repo at https://oss.sonatype.org/content/repositories/snapshots/)