MVP Review: User Authentication

[RosemaryGonzaga]

Nice work, Lianne! I have some points of feedback below. No need to drop what you're currently working on, but try to address these by next Thursday.

Signup and login functionality

• Modals should close automatically when you successfully login/signup
• Demo login isn't working

Rendering errors

• You're currently not rendering any error messages, so the user doesn't know what's wrong when they try to sign up or log in with invalid input. Add error rendering.

Styling

• Make the placeholder font bigger. Increase font sizes for session form headers, placeholder text in form inputs, and the signup/login links in the splash page's navbar.
• Add border radius to inputs
• Add hover effect to darken the background of the Sign up link.
• When the input is focused (user clicks into it), the border should be darker, thicker, and have square edges (no border radius, unlike the usual styling)
• Add more whitespace between the header and the top of the first form input (it looks cramped). The large chunk of empty space in the login form looks out of place. Adjust the height of the login form to remove the gap.
• Add an icon or image to your OpenTable logo (to display in the top navbar in the splash page)
• Add footer to the splash page; you can later use this section to display links to your LinkedIn and other professional sites.
• Add a favicon (the little icon that appears on your webpage tab to the left of your webpage name).
  - To do this, include your favicon image in your “assets/images” folder, and then add this line to your application.html.erb:
  <%= favicon_link_tag asset_path('filename.ext') %>.
  You can use any image you want as your icon, or you can generate your own. Here's a handy icon generator: https://favicon.io/favicon-generator/.