Skip to content

Commit 27e8200

Browse files
committed
fixed insight model
1 parent 34fc2a5 commit 27e8200

File tree

5 files changed

+8
-41
lines changed

5 files changed

+8
-41
lines changed

Src/LineDevelopers.Tests/LineInsightClientTest.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ await _client.Message.SendBroadcastMessageAsync(new TextMessage("static test"),
4444
}
4545
});
4646

47-
await Task.Delay(1000);
47+
await Task.Delay(10000);
4848

4949
var result = await _client.Insight.GetUserInteractionStatisticsAsync(requestId);
5050

51-
That(result.Overview.RequestId, Is.EqualTo(requestId));
51+
That(result.Overview.RequestId, Is.EqualTo(requestId),$"err : {result.Overview.RequestId} : {requestId}");
5252
});
5353
}
5454

@@ -57,10 +57,13 @@ public void GetStatisticsPerUnitAsyncTest()
5757
{
5858
DoesNotThrowAsync(async () =>
5959
{
60-
await _client.Insight.GetStatisticsPerUnitAsync("DUMMY", new DateOnly(2023, 04, 01), new DateOnly(2023, 04, 10));
60+
var result = await _client.Insight.GetStatisticsPerUnitAsync("Promotion_TEST", new DateOnly(2023, 7, 31), new DateOnly(2023, 7, 31));
61+
62+
That(result.Messages.Count, Is.EqualTo(2));
6163
});
6264
}
6365

66+
6467
[Test]
6568
public void GetNumberOfFollowersAsyncTest()
6669
{

Src/LineDevelopers/LineDevelopers.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,4 @@
2929
</None>
3030
</ItemGroup>
3131

32-
<ItemGroup>
33-
<Folder Include="Message\Content\" />
34-
</ItemGroup>
35-
3632
</Project>

Src/LineDevelopers/LineHttpClient.cs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -115,17 +115,6 @@ protected async Task<Stream> GetStreamAsync(string endpoint, Action<HttpResponse
115115
return await response.Content?.ReadAsStreamAsync();
116116
}
117117

118-
protected async Task<Stream> GetStreamAsync(string endpoint, Action<HttpContentHeaders,HttpResponseHeaders>? getResponseHeaders = null)
119-
{
120-
var response = await _httpClient.GetAsync(endpoint).ConfigureAwait(false);
121-
122-
if (getResponseHeaders != null) getResponseHeaders(response.Content.Headers, response.Headers);
123-
124-
await this.EnsureSuccessStatusCodeAsync(response).ConfigureAwait(false);
125-
126-
return await response.Content?.ReadAsStreamAsync();
127-
}
128-
129118
protected async Task PostAsync(string endpoint, StreamContent streamContent, MediaType mediaType, Action<HttpResponseHeaders>? getResponseHeaders = null)
130119
{
131120
using (var request = new HttpRequestMessage(HttpMethod.Post, endpoint))

Src/LineDevelopers/Message/Insights/StatisticsMessage.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ public class StatisticsMessage
88
public int Seq { get; set; }
99

1010
[JsonPropertyName("impression")]
11-
public int Impression { get; set; }
11+
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
12+
public int? Impression { get; set; }
1213

1314
[JsonPropertyName("mediaPlayed")]
1415
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]

Src/LineDevelopers/Message/LineContentClient.cs

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)