Skip to content

Commit 14f6d94

Browse files
Andrii BoichukAndrii Boichuk
authored andcommitted
Merge branch 'WD_1.X_dev' of https://portal-ua.globallogic.com/git/wd into WD_1.X_dev
2 parents 269f993 + d748c6c commit 14f6d94

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

src/Test/shutdown_command.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#include <iostream>
33
#include "webdriver_server.h"
44

5-
#include <QtGui/QApplication>
65
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
76
#include <QtConcurrent/QtConcurrentRun>
87
#include <QtWidgets/QApplication>

src/webdriver/webdriver_session.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,11 +406,14 @@ void Session::RemoveView(const ViewId& viewId) {
406406

407407
void Session::UpdateViews(const std::set<ViewId>& views) {
408408
ViewsMap::iterator it;
409+
ViewId vi;
409410

410411
for (it = views_.begin(); it != views_.end(); ++it) {
411-
if (0 == views.count(ViewId(it->first))) {
412+
vi = ViewId(it->first);
413+
414+
if (vi.is_valid() && 0 == views.count(vi)) {
412415
// invalidate handle
413-
RemoveView(ViewId(it->first));
416+
RemoveView(vi);
414417
}
415418
}
416419
}

src/webdriver/webdriver_view_enumerator.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ void ViewEnumerator::EnumerateViews(Session* session, std::vector<ViewId>* views
1919
std::copy(views_set.begin(), views_set.end(), std::back_inserter(*views));
2020

2121
// update session to remove dangling sessionIds
22-
session->logger().Log(kFineLogLevel, base::StringPrintf("EnumerateViews found %d views.", views_set.size()));
22+
session->logger().Log(kFineLogLevel, base::StringPrintf("EnumerateViews found %d views.", (int)views_set.size()));
2323
session->UpdateViews(views_set);
2424
}
2525

wd_build_options.gypi

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,13 @@
7777
'action': ['mkdir', '-p', '<(INTERMEDIATE_DIR)'],
7878
} ],
7979

80-
'defines': [
80+
'defines': [
8181
'OS_POSIX',
82-
],
83-
} ],
82+
],
83+
84+
'xcode_settings': {
85+
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',
86+
},
87+
} ],
8488
],
8589
}

0 commit comments

Comments
 (0)