Skip to content

Commit 203277c

Browse files
Andrii MorozAndrii Moroz
authored andcommitted
Refactored WDEventDispatcher
1 parent 2c96681 commit 203277c

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

inc/extension_qt/wd_event_dispatcher.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ class WDEventDispatcher
1515
static WDEventDispatcher *getInstance();
1616
void add(EventDispatcher *dispatcher);
1717
QVector<EventDispatcher*>& getDispatchers();
18+
bool dispatch(QEvent *event);
1819

1920
private:
2021
static WDEventDispatcher *_instance;

src/webdriver/extension_qt/wd_event_dispatcher.cc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,15 @@ QVector<EventDispatcher*>& WDEventDispatcher::getDispatchers()
3030
{
3131
return _dispatchers;
3232
}
33+
34+
bool WDEventDispatcher::dispatch(QEvent *event)
35+
{
36+
bool consumed = false;
37+
QVector<EventDispatcher*> dispatchers = WDEventDispatcher::getInstance()->getDispatchers();
38+
foreach (EventDispatcher* item, dispatchers)
39+
{
40+
consumed |= item->dispatch(event, consumed);
41+
}
42+
43+
return consumed;
44+
}

src/webdriver/extension_qt/web_view_executor.cc

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -330,14 +330,8 @@ void QWebViewCmdExecutor::SendKeys(const ElementId& element, const string16& key
330330
std::vector<QKeyEvent>::iterator it = key_events.begin();
331331
while (it != key_events.end()) {
332332

333-
//////////////////////
334-
bool consumed = false;
335-
QVector<EventDispatcher*> dispatchers = WDEventDispatcher::getInstance()->getDispatchers();
336-
foreach (EventDispatcher* item, dispatchers)
337-
{
338-
consumed |= item->dispatch(&(*it), consumed);
339-
}
340-
//////////////////////
333+
bool consumed = WDEventDispatcher::getInstance()->dispatch(&(*it));
334+
341335
if (!consumed)
342336
qApp->sendEvent(view, &(*it));
343337
++it;

src/webdriver/extension_qt/widget_view_executor.cc

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -168,14 +168,7 @@ void QWidgetViewCmdExecutor::SendKeys(const ElementId& element, const string16&
168168
std::vector<QKeyEvent>::iterator it = key_events.begin();
169169
while (it != key_events.end()) {
170170

171-
//////////////////////
172-
bool consumed = false;
173-
QVector<EventDispatcher*> dispatchers = WDEventDispatcher::getInstance()->getDispatchers();
174-
foreach (EventDispatcher* item, dispatchers)
175-
{
176-
consumed |= item->dispatch(&(*it), consumed);
177-
}
178-
//////////////////////
171+
bool consumed = WDEventDispatcher::getInstance()->dispatch(&(*it));
179172

180173
if (!consumed)
181174
qApp->sendEvent(pWidget, &(*it));

0 commit comments

Comments
 (0)