Skip to content

Commit 24526b9

Browse files
committed
remove WindowWithDeclarativeViewTest for qt5
1 parent e895f10 commit 24526b9

File tree

3 files changed

+14
-35
lines changed

3 files changed

+14
-35
lines changed

src/Test/WindowWithDeclarativeViewTest.cc

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,10 @@ WindowWithDeclarativeViewTestWidget::WindowWithDeclarativeViewTestWidget(QWidget
1616
pLabel->setObjectName("labelStatus");
1717
pLabel->setVisible(true);
1818

19-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
20-
pView = new QQuickView();
21-
#else
2219
pView = new QDeclarativeView();
23-
#endif
24-
2520
pView->setObjectName("declarativeView");
2621

27-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
28-
connect(pView, SIGNAL(statusChanged(QQuickView::Status)), this, SLOT(displayStatus()));
29-
#else
3022
connect(pView, SIGNAL(statusChanged(QDeclarativeView::Status)), this, SLOT(displayStatus()));
31-
#endif
3223

3324
QHBoxLayout* hbl = new QHBoxLayout();
3425
hbl->addWidget(pLineEdit);
@@ -37,12 +28,9 @@ WindowWithDeclarativeViewTestWidget::WindowWithDeclarativeViewTestWidget(QWidget
3728
QVBoxLayout *vbl = new QVBoxLayout(this);
3829
vbl->addLayout(hbl);
3930
vbl->addWidget(pLabel);
40-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
41-
QWidget *container = QWidget::createWindowContainer(pView);
42-
vbl->addWidget(container);
43-
#else
31+
4432
vbl->addWidget(pView);
45-
#endif
33+
4634
this->setLayout(vbl);
4735
}
4836

@@ -54,17 +42,13 @@ void WindowWithDeclarativeViewTestWidget::loadQML() {
5442
}
5543

5644
void WindowWithDeclarativeViewTestWidget::displayStatus() {
57-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
58-
if (pView->status() == QQuickView::Ready)
59-
#else
60-
if (pView->status() == QDeclarativeView::Ready)
61-
#endif
45+
46+
if (pView->status() == QDeclarativeView::Ready) {
6247
pLabel->setText("Loading successfully");
48+
return;
49+
}
6350

64-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
65-
if (pView->status() == QQuickView::Error)
66-
#else
67-
if (pView->status() == QDeclarativeView::Error)
68-
#endif
51+
if (pView->status() == QDeclarativeView::Error) {
6952
pLabel->setText("Error");
53+
}
7054
}

src/Test/WindowWithDeclarativeViewTest.h

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,7 @@
33

44
#include "CommonQtTestHeaders.h"
55

6-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
7-
#include <QtQuick/QQuickView>
8-
#else
96
#include <QtDeclarative/QDeclarativeView>
10-
#endif
11-
127

138
class WindowWithDeclarativeViewTestWidget : public QWidget
149
{
@@ -25,12 +20,8 @@ public slots:
2520
QPushButton* pButton;
2621
QLineEdit* pLineEdit;
2722
QLabel *pLabel;
28-
29-
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
30-
QQuickView *pView;
31-
#else
3223
QDeclarativeView *pView;
33-
#endif
24+
3425

3526
};
3627

src/Test/main.cc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,9 @@ std::string tests::testDataFolder;
3636
#include "VisibilityTest.h"
3737
#include "BasicMouseInterfaceTest.h"
3838

39+
#if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
3940
#include "WindowWithDeclarativeViewTest.h"
41+
#endif
4042

4143
// Commented VideoTest due to error https://bugreports.qt-project.org/browse/QTBUG-32949
4244
#ifndef OS_IOS
@@ -132,7 +134,9 @@ int main(int argc, char *argv[])
132134
widgetCreator->RegisterViewClass<StaleElementReferenceTestWidget>("StaleElementReferenceTestWidget");
133135
widgetCreator->RegisterViewClass<VisibilityTestWidget>("VisibilityTestWidget");
134136
widgetCreator->RegisterViewClass<BasicMouseInterfaceTestWidget>("BasicMouseInterfaceTestWidget");
137+
#if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
135138
widgetCreator->RegisterViewClass<WindowWithDeclarativeViewTestWidget>("WindowWithDeclarativeViewTestWidget");
139+
#endif
136140

137141
#ifndef OS_IOS
138142
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
@@ -178,7 +182,7 @@ int main(int argc, char *argv[])
178182
qmlRegisterType<QDeclarativeWebView>("CiscoQtWebKit", 1, 1, "CiscoWebView");
179183
qmlRegisterRevision<QDeclarativeWebView, 0>("CiscoQtWebKit", 1, 0);
180184
qmlRegisterRevision<QDeclarativeWebView, 1>("CiscoQtWebKit", 1, 1);
181-
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::QmlWebViewEnumeratorImpl());
185+
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::QmlWebViewEnumeratorImpl());
182186
webdriver::ViewCmdExecutorFactory::GetInstance()->AddViewCmdExecutorCreator(new webdriver::QmlWebViewCmdExecutorCreator());
183187
#endif
184188

0 commit comments

Comments
 (0)