Skip to content

Commit 3ddafed

Browse files
committed
fixed some cppcheck warns
1 parent b14cdb1 commit 3ddafed

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

src/webdriver/extension_qt/qwebkit_proxy.cc

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,7 @@ Error* QWebkitProxy::IsElementCanBeToggled(const ElementId& element, bool* can_b
377377

378378
Error* QWebkitProxy::ToggleOptionElement(const ElementId& element) {
379379
bool is_selected;
380-
Error* error = NULL;
381-
error = IsOptionElementSelected(element, &is_selected);
380+
Error* error = IsOptionElementSelected(element, &is_selected);
382381
if (error)
383382
return error;
384383

@@ -433,9 +432,8 @@ Error* QWebkitProxy::GetElementCssProperty(const ElementId& element, const std::
433432
}
434433

435434
Error* QWebkitProxy::FindElement(const ElementId& root_element, const std::string& locator, const std::string& query, ElementId* element) {
436-
Error* error = NULL;
437435
std::vector<ElementId> elements;
438-
error = FindElementsHelper(
436+
Error* error = FindElementsHelper(
439437
GetFrame(page_, session_->current_frame()),
440438
root_element, locator, query, true, &elements);
441439
if (!error)
@@ -1324,7 +1322,7 @@ Error* QWebkitProxy::FindElementsHelper(QWebFrame* frame,
13241322
if (error)
13251323
return error;
13261324

1327-
if (temp_elements.size() > 0u) {
1325+
if (!temp_elements.empty()) {
13281326
elements->swap(temp_elements);
13291327
break;
13301328
}
@@ -1617,10 +1615,9 @@ Error* QWebkitProxy::GetElementFirstClientRect(QWebFrame* frame,
16171615

16181616
Error* QWebkitProxy::GetClickableLocation(const ElementId& element, Point* location) {
16191617
bool is_displayed = false;
1620-
Error* error = NULL;
1621-
error = IsElementDisplayed(element,
1622-
true /* ignore_opacity */,
1623-
&is_displayed);
1618+
Error* error = IsElementDisplayed(element,
1619+
true /* ignore_opacity */,
1620+
&is_displayed);
16241621
if (error)
16251622
return error;
16261623
if (!is_displayed)

src/webdriver/webdriver_server.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ int Server::Stop(bool force) {
173173

174174
GlobalLogger::Log(kInfoLogLevel, "Server::Stop().");
175175

176-
if ((false == force) && (sessions.size() > 0)) {
176+
if ((false == force) && (!sessions.empty())) {
177177
GlobalLogger::Log(kInfoLogLevel, "Server::Stop() force = false, still sessions are active, failed.");
178178
return 1;
179179
}

src/webdriver/webdriver_session.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ ElementId Session::GetElementIdForHandle(const ViewId& viewId, const ElementHand
445445
return ElementId();
446446

447447
const ElementsMap& elements = viewIt->second;
448-
for (ElementsMap::const_iterator elementIt = elements.begin(); elementIt != elements.end(); elementIt++) {
448+
for (ElementsMap::const_iterator elementIt = elements.begin(); elementIt != elements.end(); ++elementIt) {
449449
if (elementIt->second->equals(handle)) {
450450
return ElementId(elementIt->first);
451451
}

0 commit comments

Comments
 (0)