Added browser connection command for QGraphicsWebView and QDeclarativeWebView

Author: nataliakoval

inc/extension_qt/graphics_web_view_executor.h

@@ -127,8 +127,8 @@ class GraphicsWebViewCmdExecutor : public ViewCmdExecutor {
     virtual void AcceptOrDismissAlert(bool accept, Error** error) NOT_SUPPORTED_IMPL;
     virtual void SetOrientation(const std::string &orientation, Error **error) NOT_SUPPORTED_IMPL;
     virtual void GetOrientation(std::string *orientation, Error **error);
-    virtual void SetOnline(bool, Error** error) NOT_SUPPORTED_IMPL;
-    virtual void IsOnline(bool*, Error** error) NOT_SUPPORTED_IMPL;
+    virtual void SetOnline(bool, Error** error);
+    virtual void IsOnline(bool*, Error** error);
 
 protected:
     QGraphicsWebView* getView(const ViewId& viewId, Error** error);

inc/extension_qt/qml_web_view_executor.h

@@ -128,8 +128,8 @@ class QmlWebViewCmdExecutor : public ViewCmdExecutor {
     virtual void AcceptOrDismissAlert(bool accept, Error** error) NOT_SUPPORTED_IMPL;
     virtual void SetOrientation(const std::string &orientation, Error **error) NOT_SUPPORTED_IMPL;
     virtual void GetOrientation(std::string *orientation, Error **error);
-    virtual void SetOnline(bool, Error** error) NOT_SUPPORTED_IMPL;
-    virtual void IsOnline(bool*, Error** error) NOT_SUPPORTED_IMPL;
+    virtual void SetOnline(bool, Error** error);
+    virtual void IsOnline(bool*, Error** error);
 
 protected:
     QDeclarativeWebView* getView(const ViewId& viewId, Error** error);

src/webdriver/extension_qt/graphics_web_view_executor.cc

@@ -716,4 +716,17 @@ void GraphicsWebViewCmdExecutor::GetOrientation(std::string *orientation, Error
     // TODO:
 }
 
+void GraphicsWebViewCmdExecutor::SetOnline(bool online, Error** error) {
+    CHECK_VIEW_EXISTANCE
+
+    *error = webkitProxy_->SetOnline(online);
+}
+
+void GraphicsWebViewCmdExecutor::IsOnline(bool* online, Error** error) {
+    CHECK_VIEW_EXISTANCE
+
+    *error = webkitProxy_->IsOnline(online);
+}
+
+
 } // namespace webdriver     

src/webdriver/extension_qt/qml_web_view_executor.cc

@@ -724,4 +724,16 @@ void QmlWebViewCmdExecutor::GetOrientation(std::string *orientation, Error **err
     // TODO:
 }
 
+void QmlWebViewCmdExecutor::SetOnline(bool online, Error** error) {
+    CHECK_VIEW_EXISTANCE
+
+    *error = webkitProxy_->SetOnline(online);
+}
+
+void QmlWebViewCmdExecutor::IsOnline(bool* online, Error** error) {
+    CHECK_VIEW_EXISTANCE
+
+    *error = webkitProxy_->IsOnline(online);
+}
+
 } // namespace webdriver     

src/webdriver/extension_qt/qwebkit_proxy.cc

@@ -1075,6 +1075,27 @@ Error* QWebkitProxy::GetMute(const ElementId& element, bool* mute) {
     return NULL;
 }
 
+Error* QWebkitProxy::SetOnline(bool online) {
+    QNetworkAccessManager *manager = page_->networkAccessManager();
+
+    if (online){
+        manager->setNetworkAccessible(QNetworkAccessManager::Accessible);
+    } else {
+        manager->setNetworkAccessible(QNetworkAccessManager::NotAccessible);
+    }
+    return NULL;
+}
+
+Error* QWebkitProxy::IsOnline(bool* online) {
+    QNetworkAccessManager *manager = page_->networkAccessManager();
+    if (manager->networkAccessible() == QNetworkAccessManager::NotAccessible) {
+        *online = false;
+    } else {
+        *online = true;
+    }
+    return NULL;
+}
+
 QWebFrame* QWebkitProxy::GetFrame(QWebPage* page, const FramePath& frame_path) {
     QWebFrame* frame = FindFrameByPath(page->mainFrame(), frame_path);
     if (frame == NULL)

src/webdriver/extension_qt/qwebkit_proxy.h

@@ -178,6 +178,8 @@ class QWebkitProxy {
     virtual Error* SetPlaybackSpeed(const ElementId& element, const double speed);
     virtual Error* SetMute(const ElementId& element, bool mute);
     virtual Error* GetMute(const ElementId& element, bool* mute);
+    virtual Error* SetOnline(bool online);
+    virtual Error* IsOnline(bool* online);
 
 protected:
     Session* session_;

src/webdriver/extension_qt/web_view_executor.cc

@@ -759,22 +759,15 @@ void QWebViewCmdExecutor::VisualizerShowPoint(Error** error) {
 }
 
 void QWebViewCmdExecutor::SetOnline(bool online, Error** error) {
-    QNetworkAccessManager *manager = view_->page()->networkAccessManager();
+    CHECK_VIEW_EXISTANCE
 
-    if (online){
-        manager->setNetworkAccessible(QNetworkAccessManager::Accessible);
-    } else {
-        manager->setNetworkAccessible(QNetworkAccessManager::NotAccessible);
-    }
+    *error = webkitProxy_->SetOnline(online);
 }
 
 void QWebViewCmdExecutor::IsOnline(bool* online, Error** error) {
-    QNetworkAccessManager *manager = view_->page()->networkAccessManager();
-    if (manager->networkAccessible() == QNetworkAccessManager::NotAccessible) {
-        *online = false;
-    } else {
-        *online = true;
-    }
+    CHECK_VIEW_EXISTANCE
+
+    *error = webkitProxy_->IsOnline(online);
 }