Skip to content

Commit 6f7a63e

Browse files
committed
small refactoring in web view creator
1 parent 743c17d commit 6f7a63e

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

src/webdriver/extension_qt/web_view_creator.cc

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,25 +47,13 @@ bool QWebViewCreator::CreateViewByClassName(const Logger& logger, const std::str
4747
}
4848

4949
bool QWebViewCreator::CreateViewForUrl(const Logger& logger, const std::string& url, ViewHandle** view) const {
50-
if (factory.empty())
51-
return false;
52-
5350
Error* tmp_err = NULL;
5451
if (!QWebViewUtil::isUrlSupported(url, &tmp_err)) {
5552
if (tmp_err) delete tmp_err;
5653
return false;
5754
}
5855

59-
// get first found QWebView
60-
CreateViewMethod createMethod = factory.begin()->second;
61-
ViewHandle* handle = new QViewHandle(static_cast<QWidget*>(createMethod()));
62-
63-
if (NULL != handle && ShowView(logger, handle)) {
64-
*view = handle;
65-
return true;
66-
}
67-
68-
return false;
56+
return CreateViewByClassName(logger, "", view);
6957
}
7058

7159
bool QWebViewCreator::ShowView(const Logger& logger, ViewHandle* viewHandle) const {

0 commit comments

Comments
 (0)