Skip to content

Commit 7739884

Browse files
Andrii BoichukAndrii Boichuk
authored andcommitted
Add RemotePlayerSpeed command
1 parent 1510544 commit 7739884

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/webdriver/commands/cisco_player_commands.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ void CISCO_PlaybackSpeedCommand::ExecuteGet(Response * const response)
303303
return;
304304
}
305305

306-
Value* value = Value::CreateBooleanValue(speed);
306+
Value* value = Value::CreateDoubleValue(speed);
307307
response->SetValue(value);
308308
}
309309

src/webdriver/extension_qt/qwebkit_proxy.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1012,8 +1012,8 @@ Error* QWebkitProxy::SetPlayingPosition(const ElementId& element, const double r
10121012

10131013
Error* error = ExecuteScriptAndParse(
10141014
GetFrame(page_, session_->current_frame()),
1015-
"function(elem, time) { elem.currentTime = time; }",
1016-
"setVolume",
1015+
"function(elem, time) { elem. = false; elem.currentTime = time; }",
1016+
"setPosition",
10171017
CreateListValueFrom(element, reletivePos),
10181018
CreateDirectValueParser(&value));
10191019
scoped_ptr<Value> scoped_value(value);
@@ -1024,7 +1024,7 @@ Error* QWebkitProxy::SetPlayingPosition(const ElementId& element, const double r
10241024
Error *QWebkitProxy::GetPlaybackSpeed(const ElementId &element, double *speed)
10251025
{
10261026
base::Value* speedValue = NULL;
1027-
Error* error = GetAttribute(element, std::string("currentTime"), &speedValue);
1027+
Error* error = GetAttribute(element, std::string("playbackRate"), &speedValue);
10281028
scoped_ptr<base::Value> scoped_position_value(speedValue);
10291029
if(error)
10301030
return error;

src/webdriver/webdriver_route_table.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ DefaultRouteTable::DefaultRouteTable()
314314
Add<CISCO_VolumeCommand> (CommandRoutes::kCiscoPlayerVolume);
315315
Add<CISCO_SeekCommand> (CommandRoutes::kCiscoPlayingPosition);
316316
Add<CISCO_MuteCommand> (CommandRoutes::kCiscoPlayerMute);
317+
Add<CISCO_PlaybackSpeedCommand> (CommandRoutes::kCiscoPlayerPlayingSpeed);
317318
Add<VisualizerSourceCommand> (CommandRoutes::kVisualizerSource);
318319
Add<VisualizerShowPointCommand> (CommandRoutes::kVisualizerShowPoint);
319320

0 commit comments

Comments
 (0)