Skip to content

Commit 7d75717

Browse files
committed
code's cleanup
1 parent b793fb1 commit 7d75717

File tree

2 files changed

+10
-58
lines changed

2 files changed

+10
-58
lines changed

inc/extension_qt/qml_web_view_executor.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,16 @@ class QmlWebViewCmdExecutor : public ViewCmdExecutor {
100100
virtual void GetStorageSize(StorageType type, int* size, Error** error);
101101
virtual void GetGeoLocation(base::DictionaryValue** geolocation, Error** error) NOT_SUPPORTED_IMPL;
102102
virtual void SetGeoLocation(const base::DictionaryValue* geolocation, Error** error) NOT_SUPPORTED_IMPL;
103-
virtual void TouchClick(const ElementId& element, Error **error);
104-
virtual void TouchDoubleClick(const ElementId& element, Error **error);
105-
virtual void TouchDown(const int &x, const int &y, Error **error);
106-
virtual void TouchUp(const int &x, const int &y, Error **error);
107-
virtual void TouchMove(const int &x, const int &y, Error **error);
108-
virtual void TouchLongClick(const ElementId& element, Error **error);
109-
virtual void TouchScroll(const int &xoffset, const int &yoffset, Error **error);
110-
virtual void TouchScroll(const ElementId &element, const int &xoffset, const int &yoffset, Error **error);
111-
virtual void TouchFlick(const int &xSpeed, const int &ySpeed, Error **error);
112-
virtual void TouchFlick(const ElementId &element, const int &xoffset, const int &yoffset, const int &speed, Error **error);
103+
virtual void TouchClick(const ElementId& element, Error **error) NOT_SUPPORTED_IMPL;
104+
virtual void TouchDoubleClick(const ElementId& element, Error **error) NOT_SUPPORTED_IMPL;
105+
virtual void TouchDown(const int &x, const int &y, Error **error) NOT_SUPPORTED_IMPL;
106+
virtual void TouchUp(const int &x, const int &y, Error **error) NOT_SUPPORTED_IMPL;
107+
virtual void TouchMove(const int &x, const int &y, Error **error) NOT_SUPPORTED_IMPL;
108+
virtual void TouchLongClick(const ElementId& element, Error **error) NOT_SUPPORTED_IMPL;
109+
virtual void TouchScroll(const int &xoffset, const int &yoffset, Error **error) NOT_SUPPORTED_IMPL;
110+
virtual void TouchScroll(const ElementId &element, const int &xoffset, const int &yoffset, Error **error) NOT_SUPPORTED_IMPL;
111+
virtual void TouchFlick(const int &xSpeed, const int &ySpeed, Error **error) NOT_SUPPORTED_IMPL;
112+
virtual void TouchFlick(const ElementId &element, const int &xoffset, const int &yoffset, const int &speed, Error **error) NOT_SUPPORTED_IMPL;
113113
virtual void GetBrowserLog(base::ListValue** browserLog, Error **error);
114114
virtual void GetPlayerState(const ElementId& element, PlayerState*, Error**);
115115
virtual void SetPlayerState(const ElementId& element, PlayerState, Error**);

src/webdriver/extension_qt/qml_web_view_executor.cc

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -644,54 +644,6 @@ void QmlWebViewCmdExecutor::GetStorageSize(StorageType type, int* size, Error**
644644
*error = webkitProxy_->GetStorageSize(type, size);
645645
}
646646

647-
void QmlWebViewCmdExecutor::TouchClick(const ElementId& element, Error **error) {
648-
// TODO:
649-
}
650-
651-
void QmlWebViewCmdExecutor::TouchDoubleClick(const ElementId& element, Error **error) {
652-
// TODO:
653-
}
654-
655-
void QmlWebViewCmdExecutor::TouchDown(const int &x, const int &y, Error **error) {
656-
// TODO:
657-
}
658-
659-
void QmlWebViewCmdExecutor::TouchUp(const int &x, const int &y, Error **error) {
660-
// TODO:
661-
}
662-
663-
void QmlWebViewCmdExecutor::TouchMove(const int &x, const int &y, Error **error) {
664-
// TODO:
665-
}
666-
667-
void QmlWebViewCmdExecutor::TouchLongClick(const ElementId& element, Error **error) {
668-
// TODO:
669-
}
670-
671-
void QmlWebViewCmdExecutor::TouchScroll(const int &xoffset, const int &yoffset, Error **error) {
672-
CHECK_VIEW_EXISTANCE
673-
674-
view_->page()->mainFrame()->scroll(xoffset, yoffset);
675-
}
676-
677-
void QmlWebViewCmdExecutor::TouchScroll(const ElementId &element, const int &xoffset, const int &yoffset, Error **error) {
678-
CHECK_VIEW_EXISTANCE
679-
680-
view_->page()->mainFrame()->scroll(-xoffset, -yoffset);
681-
}
682-
683-
void QmlWebViewCmdExecutor::TouchFlick(const int &xSpeed, const int &ySpeed, Error **error) {
684-
CHECK_VIEW_EXISTANCE
685-
686-
view_->page()->mainFrame()->scroll(xSpeed*3, ySpeed*3);
687-
}
688-
689-
void QmlWebViewCmdExecutor::TouchFlick(const ElementId &element, const int &xoffset, const int &yoffset, const int &speed, Error **error) {
690-
CHECK_VIEW_EXISTANCE
691-
692-
view_->page()->mainFrame()->scroll(-xoffset*(speed+1), -yoffset*(speed+1));
693-
}
694-
695647
void QmlWebViewCmdExecutor::GetBrowserLog(base::ListValue** browserLog, Error **error) {
696648
CHECK_VIEW_EXISTANCE
697649

0 commit comments

Comments
 (0)