Skip to content

Commit 84a9fdb

Browse files
committed
added some logs to show size/position
1 parent bbf7a48 commit 84a9fdb

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

src/webdriver/extension_qt/qml_view_creator.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "extension_qt/widget_view_handle.h"
99
#include "q_content_type_resolver.h"
1010
#include "q_event_filter.h"
11+
#include "base/string_number_conversions.h"
1112

1213
#include <QtNetwork/QNetworkAccessManager>
1314
#include <QtCore/QString>
@@ -72,7 +73,8 @@ bool QQmlViewCreator::CreateViewByClassName(const Logger& logger, const std::str
7273
int x_offset = widget->geometry().x() - widget->frameGeometry().x();
7374
int y_offset = widget->geometry().y() - widget->frameGeometry().y();
7475
widget->move(position->x() - x_offset, position->y() - y_offset);
75-
logger.Log(kInfoLogLevel, "Applying desired position for qml.");
76+
logger.Log(kInfoLogLevel, "Applying desired position (" + base::IntToString(position->x()) + ", "
77+
+ base::IntToString(position->y())+") for qml.");
7678
}
7779

7880
*view = handle;

src/webdriver/extension_qt/quick2_view_creator.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "extension_qt/qwindow_view_handle.h"
99
#include "q_content_type_resolver.h"
1010
#include "q_event_filter.h"
11+
#include "base/string_number_conversions.h"
1112

1213
#include <QtNetwork/QNetworkAccessManager>
1314
#include <QtCore/QString>
@@ -70,7 +71,8 @@ bool Quick2ViewCreator::CreateViewByClassName(const Logger& logger, const std::s
7071
if (NULL != position) {
7172
pWindow->setX(position->x());
7273
pWindow->setY(position->y());
73-
logger.Log(kInfoLogLevel, "Applying desired position for quick2.");
74+
logger.Log(kInfoLogLevel, "Applying desired position (" + base::IntToString(position->x()) + ", "
75+
+ base::IntToString(position->y())+") for quick2.");
7476
}
7577

7678
*view = handle;

src/webdriver/extension_qt/web_view_creator.cc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include "common_util.h"
1010
#include "q_content_type_resolver.h"
1111
#include "q_event_filter.h"
12+
#include "base/string_number_conversions.h"
1213

1314
#include <QtNetwork/QNetworkAccessManager>
1415
#include <QtCore/QString>
@@ -47,13 +48,20 @@ bool QWebViewCreator::CreateViewByClassName(const Logger& logger, const std::str
4748
if (NULL != size && NULL != position) {
4849
Rect* rect = new Rect(*position, *size);
4950
widget->setGeometry(QCommonUtil::ConvertRectToQRect(*rect));
51+
logger.Log(kInfoLogLevel, "Applying desired position (" + base::IntToString(position->x()) + ", "
52+
+ base::IntToString(position->y())+") and size (" + base::IntToString(size->width()) + ", "
53+
+ base::IntToString(size->height())+") for webview.");
5054
delete rect;
5155
} else if (NULL != size) {
5256
widget->resize(QCommonUtil::ConvertSizeToQSize(*size));
57+
logger.Log(kInfoLogLevel, "Applying desired size (" + base::IntToString(size->width()) + ", "
58+
+ base::IntToString(size->height())+") for webview.");
5359
} else if (NULL != position) {
5460
int x_offset = widget->geometry().x() - widget->frameGeometry().x();
5561
int y_offset = widget->geometry().y() - widget->frameGeometry().y();
5662
widget->move(position->x() - x_offset, position->y() - y_offset);
63+
logger.Log(kInfoLogLevel, "Applying desired position (" + base::IntToString(position->x()) + ", "
64+
+ base::IntToString(position->y())+") for webview.");
5765
}
5866
*view = handle;
5967
return true;

src/webdriver/extension_qt/widget_view_creator.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#include "widget_view_util.h"
77
#include "extension_qt/widget_view_handle.h"
88
#include "q_event_filter.h"
9+
#include "base/string_number_conversions.h"
910

1011
#include <QtCore/QEventLoop>
1112
#include <QtCore/QTimer>
@@ -73,7 +74,8 @@ bool QWidgetViewCreator::CreateViewByClassName(const Logger& logger, const std::
7374
int x_offset = widget->geometry().x() - widget->frameGeometry().x();
7475
int y_offset = widget->geometry().y() - widget->frameGeometry().y();
7576
widget->move(position->x() - x_offset, position->y() - y_offset);
76-
logger.Log(kInfoLogLevel, "Applying desired position for widget.");
77+
logger.Log(kInfoLogLevel, "Applying desired position (" + base::IntToString(position->x()) + ", "
78+
+ base::IntToString(position->y())+") for widget.");
7779
}
7880

7981
*view = handle;

0 commit comments

Comments
 (0)