Skip to content

Commit 9acac73

Browse files
author
Vasyl Vavrychuk
committed
fixing choose window functionallity
1 parent 996301b commit 9acac73

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

web/WebDriverJsDemo.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<td>Web page</td>
3535
<td>
3636
<input name="webPage" type="text" onchange="wd.onWebPageChange()" onkeyup="wd.onWebPageChange()"/>
37-
<input type="button" value="GET" onclick="wd.onGet()"/>
37+
<input id="getButton" type="button" value="GET" onclick="wd.onGet()"/>
3838
<input id="sourceButton" type="button" value="Source" onclick="wd.onSource()"/>
3939
<input id="screenshotButton" type="button" value="Screenshot" onclick="wd.onScreenshot()"/>
4040
<select onmouseup="wd.onLogs(this.options[this.selectedIndex].value)">
@@ -107,7 +107,7 @@
107107
</div>
108108

109109
<div class="commandBlock">
110-
<input type="submit" value="List window handles" onclick="wd.onListWindowHandles()"/>
110+
<input id="listWindowButton" type="submit" value="List window handles" onclick="wd.onListWindowHandles()"/>
111111
<select id="windowList" style="visibility: hidden;">
112112
</select>
113113
<input id="chooseWindow" type="submit" value="Choose window" onclick="wd.onChooseWindow()" style="visibility: hidden;"/>

web/webdriver-app.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,8 +632,10 @@ WebDriverJsController.prototype.onListWindowHandles = function() {
632632
var select = document.getElementById('windowList');
633633
this.driver.getAllWindowHandles().then(function(handles) {
634634
select.innerHTML = '';
635-
for (var handle in handles) {
635+
for (var handleIndex in handles) {
636+
var handle = handles[handleIndex];
636637
var item = document.createElement('option');
638+
item.setAttribute('value', handle);
637639
item.innerHTML = handle;
638640
select.appendChild(item)
639641
}

0 commit comments

Comments
 (0)