Skip to content

Commit b374f0c

Browse files
committed
Added QtWebkit to ignore
1 parent 07bacbd commit b374f0c

File tree

5 files changed

+17
-15
lines changed

5 files changed

+17
-15
lines changed

test/Java/test/org/openqa/selenium/testing/Ignore.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public static enum Driver {
4141
REMOTE,
4242
SAFARI,
4343
SELENESE,
44+
QTWEBKIT,
4445
}
4546

4647
Driver[] value() default {Driver.ALL};

test/Java/test/org/openqa/selenium/testing/drivers/Browser.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,13 @@ public boolean isJavascriptEnabled() {
3939
none, // For those cases where you don't actually want a browser
4040
opera,
4141
opera_mobile,
42-
safari;
42+
safari,
43+
qtwebkit;
4344

4445
private static final Logger log = Logger.getLogger(Browser.class.getName());
4546

4647
public static Browser detect() {
47-
String browserName = "chrome";//System.getProperty("selenium.browser");
48+
String browserName = "qtwebkit";//System.getProperty("selenium.browser");
4849
if (browserName == null) {
4950
log.info("No browser detected, returning null");
5051
return null;

test/Java/test/org/openqa/selenium/testing/drivers/BrowserToCapabilities.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import static org.openqa.selenium.remote.CapabilityType.HAS_NATIVE_EVENTS;
2525

26+
import org.openqa.selenium.Platform;
2627
import org.openqa.selenium.remote.DesiredCapabilities;
2728

2829
public class BrowserToCapabilities {
@@ -82,6 +83,10 @@ public static DesiredCapabilities of(Browser browser) {
8283
caps = DesiredCapabilities.iphone();
8384
break;
8485

86+
case qtwebkit:
87+
caps = new DesiredCapabilities("qtwebkit", "", Platform.ANY);
88+
break;
89+
8590
default:
8691
throw new RuntimeException("Cannot determine browser config to use");
8792
}

test/Java/test/org/openqa/selenium/testing/drivers/DefaultDriverSupplier.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.common.base.Throwables;
2424

2525
import org.openqa.selenium.Capabilities;
26+
import org.openqa.selenium.Platform;
2627
import org.openqa.selenium.WebDriver;
2728
import org.openqa.selenium.remote.DesiredCapabilities;
2829
import org.openqa.selenium.remote.RemoteWebDriver;
@@ -62,7 +63,8 @@ public WebDriver get() {
6263

6364
//try {
6465

65-
DesiredCapabilities capability = DesiredCapabilities.chrome();
66+
DesiredCapabilities capability = new DesiredCapabilities("QtWebkit", "", Platform.ANY);
67+
capability.setCapability("browserClass", "MhaWebView");
6668
URL hostURL;
6769

6870
try {

test/Java/test/org/openqa/selenium/testing/drivers/TestIgnorance.java

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,7 @@
3535
import static com.google.common.base.Preconditions.checkNotNull;
3636
import static org.openqa.selenium.Platform.LINUX;
3737
import static org.openqa.selenium.Platform.WINDOWS;
38-
import static org.openqa.selenium.testing.Ignore.Driver.ALL;
39-
import static org.openqa.selenium.testing.Ignore.Driver.ANDROID;
40-
import static org.openqa.selenium.testing.Ignore.Driver.CHROME;
41-
import static org.openqa.selenium.testing.Ignore.Driver.FIREFOX;
42-
import static org.openqa.selenium.testing.Ignore.Driver.HTMLUNIT;
43-
import static org.openqa.selenium.testing.Ignore.Driver.IE;
44-
import static org.openqa.selenium.testing.Ignore.Driver.IPHONE;
45-
import static org.openqa.selenium.testing.Ignore.Driver.OPERA;
46-
import static org.openqa.selenium.testing.Ignore.Driver.OPERA_MOBILE;
47-
import static org.openqa.selenium.testing.Ignore.Driver.REMOTE;
48-
import static org.openqa.selenium.testing.Ignore.Driver.SAFARI;
49-
import static org.openqa.selenium.testing.Ignore.Driver.SELENESE;
38+
import static org.openqa.selenium.testing.Ignore.Driver.*;
5039
import static org.openqa.selenium.testing.drivers.Browser.android;
5140
import static org.openqa.selenium.testing.drivers.Browser.chrome;
5241
import static org.openqa.selenium.testing.drivers.Browser.htmlunit;
@@ -213,6 +202,10 @@ private void addIgnoresForBrowser(Browser browser, IgnoreComparator comparator)
213202
comparator.addDriver(SAFARI);
214203
break;
215204

205+
case qtwebkit:
206+
comparator.addDriver(QTWEBKIT);
207+
break;
208+
216209
default:
217210
throw new RuntimeException("Cannot determine which ignore to add ignores rules for");
218211
}

0 commit comments

Comments
 (0)