Skip to content

Commit ba3c4d2

Browse files
committed
added test widget for graphics web view
1 parent 0956b4e commit ba3c4d2

File tree

7 files changed

+63
-3
lines changed

7 files changed

+63
-3
lines changed

inc/extension_qt/graphics_web_view_enumerator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
namespace webdriver {
1111

1212
/// class for QDeclarativeWebView enumerator
13-
class GraphicsQmlWebViewEnumeratorImpl : public AbstractViewEnumeratorImpl {
13+
class GraphicsWebViewEnumeratorImpl : public AbstractViewEnumeratorImpl {
1414
public:
1515
virtual void EnumerateViews(Session* session, std::set<ViewId>* views) const;
1616
};

src/Test/GraphicsWebViewTest.cc

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
#include "GraphicsWebViewTest.h"
2+
3+
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
4+
#include <QtWebKitWidgets/QWebView>
5+
#else
6+
#include <QtWebKit/QWebView>
7+
#endif
8+
9+
GraphicsWebViewTestWindows::GraphicsWebViewTestWindows(QWidget *parent) :
10+
QGraphicsView(parent) {
11+
this->setWindowTitle("Test Widget");
12+
13+
QGraphicsScene *pScene = new QGraphicsScene();
14+
this->setScene(pScene);
15+
this->resize(800, 600);
16+
QGraphicsWebView *pWebView = new QGraphicsWebView();
17+
this->scene()->addItem(pWebView);
18+
}
19+
20+
GraphicsWebViewTestWindows::~GraphicsWebViewTestWindows() {}
21+

src/Test/GraphicsWebViewTest.h

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
#ifndef GRAPHICS_WEB_VIEW_TEST_H
2+
#define GRAPHICS_WEB_VIEW_TEST_H
3+
4+
#include "CommonQtTestHeaders.h"
5+
6+
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
7+
#include <QtWebKitWidgets/QGraphicsWebView>
8+
#include <QtWidgets/QGraphicsView>
9+
#else
10+
#include <QtWebKit/QGraphicsWebView>
11+
#include <QtGui/QGraphicsView>
12+
#endif
13+
14+
class GraphicsWebViewTestWindows : public QGraphicsView
15+
{
16+
Q_OBJECT
17+
public:
18+
explicit GraphicsWebViewTestWindows(QWidget *parent = 0);
19+
~GraphicsWebViewTestWindows();
20+
};
21+
22+
#endif // GRAPHICS_WEB_VIEW_TEST_H

src/Test/main.cc

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ std::string tests::testDataFolder;
7979
#include "extension_qt/web_view_executor.h"
8080
#include "extension_qt/web_view_enumerator.h"
8181
#include "extension_qt/qwebviewext.h"
82+
#include "extension_qt/graphics_web_view_executor.h"
83+
#include "extension_qt/graphics_web_view_enumerator.h"
84+
#include "GraphicsWebViewTest.h"
8285
#include "WindowWithEmbeddedViewTest.h"
8386
#include "WidgetAndWebViewTest.h"
8487
#if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
@@ -155,8 +158,16 @@ int main(int argc, char *argv[])
155158
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::WebViewEnumeratorImpl());
156159

157160
webdriver::ViewCmdExecutorFactory::GetInstance()->AddViewCmdExecutorCreator(new webdriver::QWebViewCmdExecutorCreator());
161+
162+
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::GraphicsWebViewEnumeratorImpl());
163+
164+
webdriver::ViewCmdExecutorFactory::GetInstance()->AddViewCmdExecutorCreator(new webdriver::GraphicsWebViewCmdExecutorCreator());
165+
166+
widgetCreator->RegisterViewClass<GraphicsWebViewTestWindows>("GraphicsWebViewTestWindows");
158167
widgetCreator->RegisterViewClass<WindowWithEmbeddedViewTestWidget>("WindowWithEmbeddedViewTestWidget");
159168
widgetCreator->RegisterViewClass<WidgetAndWebViewTestWindows>("WidgetAndWebViewTestWindows");
169+
170+
160171
#if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
161172
widgetCreator->RegisterViewClass<WindowWithSeparatedDeclarativeAndWebViewsTestWidget>("WindowWithSeparatedDeclarativeAndWebViewsTestWidget");
162173
#endif

src/webdriver/extension_qt/graphics_web_view_enumerator.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
namespace webdriver {
2020

21-
void GraphicsQmlWebViewEnumeratorImpl::EnumerateViews(Session* session, std::set<ViewId>* views) const {
21+
void GraphicsWebViewEnumeratorImpl::EnumerateViews(Session* session, std::set<ViewId>* views) const {
2222
session->logger().Log(kInfoLogLevel, ">>>>> QGraphicsWebView enumerate");
2323

2424
foreach(QWidget* pWidget, qApp->allWidgets()) {
@@ -36,7 +36,7 @@ void GraphicsQmlWebViewEnumeratorImpl::EnumerateViews(Session* session, std::set
3636
if (!viewId.is_valid()) {
3737
if (session->AddNewView(handle, &viewId)) {
3838
session->logger().Log(kInfoLogLevel,
39-
"GraphicsQmlWebViewEnumerator found new view("+viewId.id()+")");
39+
"GraphicsWebViewEnumerator found new view("+viewId.id()+")");
4040
}
4141
}
4242
if (viewId.is_valid()) {

wd_ext_qt.gyp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@
7373
'src/webdriver/extension_qt/web_view_util.cc',
7474
'src/webdriver/extension_qt/qwebkit_proxy.cc',
7575
'src/webdriver/extension_qt/qwebkit_proxy.h',
76+
'src/webdriver/extension_qt/graphics_web_view_handle.cc',
77+
'src/webdriver/extension_qt/graphics_web_view_enumerator.cc',
78+
'src/webdriver/extension_qt/graphics_web_view_executor.cc',
7679
'inc/extension_qt/qwebviewext.h',
7780
'<(INTERMEDIATE_DIR)/moc_web_view_visualizer.cc',
7881
'<(INTERMEDIATE_DIR)/moc_qwebviewext.cc',

wd_test.gyp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,9 @@
279279
'src/Test/WidgetAndWebViewTest.cc',
280280
'src/Test/WidgetAndWebViewTest.h',
281281
'<(INTERMEDIATE_DIR)/moc_WidgetAndWebViewTest.cc',
282+
'src/Test/GraphicsWebViewTest.cc',
283+
'src/Test/GraphicsWebViewTest.h',
284+
'<(INTERMEDIATE_DIR)/moc_GraphicsWebViewTest.cc',
282285
],
283286

284287
'conditions': [

0 commit comments

Comments
 (0)