Skip to content

Commit f32ab17

Browse files
committed
fix prev commit for QT5
1 parent 3190a8e commit f32ab17

File tree

3 files changed

+23
-16
lines changed

3 files changed

+23
-16
lines changed

src/Test/WindowWithEmbeddedViewTest.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
#include "WindowWithEmbeddedViewTest.h"
2-
#include <QtWebKit/QWebView>
2+
3+
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
4+
#include <QtWebKitWidgets/QWebView>
5+
#else
6+
#include <QtWebKit/QtWebKit>
7+
#endif
8+
39

410
WindowWithEmbeddedViewTestWidget::WindowWithEmbeddedViewTestWidget(QWidget *parent) :
511
QWidget(parent)

src/Test/main.cc

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,6 @@ int main(int argc, char *argv[])
7777

7878
webdriver::ViewTransitionManager::SetURLTransitionAction(new webdriver::URLTransitionAction_CloseOldView());
7979

80-
#if (WD_TEST_ENABLE_WEB_VIEW == 1)
81-
webdriver::ViewCreator* webCreator = new webdriver::QWebViewCreator();
82-
webCreator->RegisterViewClass<QWebViewExt>("QWebViewExt");
83-
webdriver::ViewFactory::GetInstance()->AddViewCreator(webCreator);
84-
85-
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::WebViewEnumeratorImpl());
86-
87-
webdriver::ViewCmdExecutorFactory::GetInstance()->AddViewCmdExecutorCreator(new webdriver::QWebViewCmdExecutorCreator());
88-
89-
#endif
90-
9180
webdriver::ViewCreator* widgetCreator = new webdriver::QWidgetViewCreator();
9281
widgetCreator->RegisterViewClass<QWidget>("QWidget");
9382
widgetCreator->RegisterViewClass<WindowTestWidget>("WindowTestWidget");
@@ -105,8 +94,19 @@ int main(int argc, char *argv[])
10594
widgetCreator->RegisterViewClass<StaleElementReferenceTestWidget>("StaleElementReferenceTestWidget");
10695
widgetCreator->RegisterViewClass<VisibilityTestWidget>("VisibilityTestWidget");
10796
widgetCreator->RegisterViewClass<BasicMouseInterfaceTestWidget>("BasicMouseInterfaceTestWidget");
97+
98+
#if (WD_TEST_ENABLE_WEB_VIEW == 1)
99+
webdriver::ViewCreator* webCreator = new webdriver::QWebViewCreator();
100+
webCreator->RegisterViewClass<QWebViewExt>("QWebViewExt");
101+
webdriver::ViewFactory::GetInstance()->AddViewCreator(webCreator);
102+
103+
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::WebViewEnumeratorImpl());
104+
105+
webdriver::ViewCmdExecutorFactory::GetInstance()->AddViewCmdExecutorCreator(new webdriver::QWebViewCmdExecutorCreator());
108106
widgetCreator->RegisterViewClass<WindowWithEmbeddedViewTestWidget>("WindowWithEmbeddedViewTestWidget");
109107

108+
109+
#endif
110110
webdriver::ViewFactory::GetInstance()->AddViewCreator(widgetCreator);
111111

112112
webdriver::ViewEnumerator::AddViewEnumeratorImpl(new webdriver::WidgetViewEnumeratorImpl());

wd_test.gyp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@
4444
'-licuuc',
4545
'-licudata',
4646
'-licui18n',
47-
'-lQt5WebKit',
47+
# '-lQt5WebKit',
48+
'-lQt5WebKitWidgets',
4849
],
4950
} ],
5051
['OS=="win"', {
@@ -184,9 +185,6 @@
184185
'src/Test/RestyledLabel.cc',
185186
'src/Test/DragableWidget.cc',
186187
'src/Test/BasicMouseInterfaceTest.cc',
187-
'src/Test/WindowWithEmbeddedViewTest.cc',
188-
'src/Test/WindowWithEmbeddedViewTest.h',
189-
'<(INTERMEDIATE_DIR)/moc_WindowWithEmbeddedViewTest.cc'
190188
],
191189

192190
}, {
@@ -208,6 +206,9 @@
208206
'sources': [
209207
'src/Test/main.cc',
210208
'src/Test/shutdown_command.cc',
209+
'src/Test/WindowWithEmbeddedViewTest.cc',
210+
'src/Test/WindowWithEmbeddedViewTest.h',
211+
'<(INTERMEDIATE_DIR)/moc_WindowWithEmbeddedViewTest.cc',
211212
],
212213

213214
'conditions': [

0 commit comments

Comments
 (0)