From eabe5e9b443fb8fc5010200443c8772ae54e6965 Mon Sep 17 00:00:00 2001 From: Jacek Date: Thu, 19 Mar 2026 20:21:30 -0500 Subject: [PATCH 1/5] fix(ci): correct playwright trace upload path --- .github/workflows/ci.yml | 2 +- .github/workflows/e2e-staging.yml | 2 +- .github/workflows/nightly-checks.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7b35de8f625..5be729a2265 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -462,7 +462,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }} - path: integration/test-results + path: test-results retention-days: 1 pkg-pr-new: diff --git a/.github/workflows/e2e-staging.yml b/.github/workflows/e2e-staging.yml index 3267307d3a5..7c6aa25d4dc 100644 --- a/.github/workflows/e2e-staging.yml +++ b/.github/workflows/e2e-staging.yml @@ -227,7 +227,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ steps.inputs.outputs.artifact-suffix }} - path: integration/test-results + path: test-results retention-days: 1 report: diff --git a/.github/workflows/nightly-checks.yml b/.github/workflows/nightly-checks.yml index 17c5f756427..9cc8f140649 100644 --- a/.github/workflows/nightly-checks.yml +++ b/.github/workflows/nightly-checks.yml @@ -110,7 +110,7 @@ jobs: path: | ${{runner.temp}}/test-output.log /tmp/.temp_integration/ - integration/test-results/ + test-results/ retention-days: 7 - name: Report Status From 5866c8eaef52ee9701a306921939d896b33fc6ee Mon Sep 17 00:00:00 2001 From: Jacek Date: Thu, 19 Mar 2026 20:28:50 -0500 Subject: [PATCH 2/5] chore(ci): temporarily upload traces on all runs for validation --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5be729a2265..d66ededb0fd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -458,7 +458,7 @@ jobs: VERCEL_AUTOMATION_BYPASS_SECRET: ${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }} - name: Upload test-results - if: ${{ cancelled() || failure() }} + if: always() # TODO: revert to `cancelled() || failure()` after validating trace upload path uses: actions/upload-artifact@v4 with: name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }} From 5f385220ba209aad47d1b2f082f4ceee73a2a860 Mon Sep 17 00:00:00 2001 From: Jacek Date: Thu, 19 Mar 2026 20:32:06 -0500 Subject: [PATCH 3/5] chore: temporarily enable all traces for upload validation --- integration/playwright.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration/playwright.config.ts b/integration/playwright.config.ts index 007d17768cc..283e154a11a 100644 --- a/integration/playwright.config.ts +++ b/integration/playwright.config.ts @@ -19,7 +19,7 @@ export const common: PlaywrightTestConfig = { actionTimeout: 10_000, navigationTimeout: 30_000, ignoreHTTPSErrors: true, - trace: 'retain-on-failure', + trace: 'on', // TODO: revert to 'retain-on-failure' after validating trace upload path bypassCSP: true, // We probably need to limit this to specific tests }, } as const; From e5d8d2ae8ab9321efd3dbaac1a6e9b87544703a6 Mon Sep 17 00:00:00 2001 From: Jacek Date: Thu, 19 Mar 2026 20:36:09 -0500 Subject: [PATCH 4/5] chore: revert temporary trace validation changes --- .github/workflows/ci.yml | 2 +- integration/playwright.config.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d66ededb0fd..5be729a2265 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -458,7 +458,7 @@ jobs: VERCEL_AUTOMATION_BYPASS_SECRET: ${{ secrets.VERCEL_AUTOMATION_BYPASS_SECRET }} - name: Upload test-results - if: always() # TODO: revert to `cancelled() || failure()` after validating trace upload path + if: ${{ cancelled() || failure() }} uses: actions/upload-artifact@v4 with: name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }} diff --git a/integration/playwright.config.ts b/integration/playwright.config.ts index 283e154a11a..007d17768cc 100644 --- a/integration/playwright.config.ts +++ b/integration/playwright.config.ts @@ -19,7 +19,7 @@ export const common: PlaywrightTestConfig = { actionTimeout: 10_000, navigationTimeout: 30_000, ignoreHTTPSErrors: true, - trace: 'on', // TODO: revert to 'retain-on-failure' after validating trace upload path + trace: 'retain-on-failure', bypassCSP: true, // We probably need to limit this to specific tests }, } as const; From 75e9d90fd1237f01e9db8acb6274d24df8987679 Mon Sep 17 00:00:00 2001 From: Jacek Date: Thu, 19 Mar 2026 20:39:05 -0500 Subject: [PATCH 5/5] chore: add empty changeset --- .changeset/yellow-eagles-shine.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changeset/yellow-eagles-shine.md diff --git a/.changeset/yellow-eagles-shine.md b/.changeset/yellow-eagles-shine.md new file mode 100644 index 00000000000..a845151cc84 --- /dev/null +++ b/.changeset/yellow-eagles-shine.md @@ -0,0 +1,2 @@ +--- +---