chore: Turn on more ruff rules

hoodmane · hoodmane · commit f00a62434b33 · 2025-11-25T11:27:40.000-08:00
diff --git a/01-hello/src/entry.py b/01-hello/src/entry.py
@@ -1,4 +1,4 @@
-from workers import WorkerEntrypoint, Response
+from workers import Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/02-binding/src/entry.py b/02-binding/src/entry.py
@@ -1,4 +1,4 @@
-from workers import WorkerEntrypoint, Response
+from workers import Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/03-fastapi/src/worker.py b/03-fastapi/src/worker.py
@@ -1,3 +1,4 @@
+import asgi
 import jinja2
 from fastapi import FastAPI, Request
 from workers import WorkerEntrypoint
@@ -29,6 +30,4 @@ async def env(req: Request):
 
 class Default(WorkerEntrypoint):
     async def fetch(self, request):
-        import asgi
-
         return await asgi.fetch(app, request.js_object, self.env)
diff --git a/04-query-d1/src/entry.py b/04-query-d1/src/entry.py
@@ -1,4 +1,4 @@
-from workers import WorkerEntrypoint, Response
+from workers import Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/05-langchain/src/worker.py b/05-langchain/src/worker.py
@@ -1,6 +1,6 @@
-from workers import WorkerEntrypoint, Response
 from langchain_core.prompts import PromptTemplate
 from langchain_openai import OpenAI
+from workers import Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/06-assets/src/worker.py b/06-assets/src/worker.py
@@ -1,6 +1,7 @@
-from workers import WorkerEntrypoint, Response
 from urllib.parse import urlparse
 
+from workers import Response, WorkerEntrypoint
+
 INDEX_PAGE = """
 <!DOCTYPE html>
 <html>
diff --git a/07-durable-objects/src/entry.py b/07-durable-objects/src/entry.py
@@ -1,7 +1,8 @@
-from workers import WorkerEntrypoint, Response, DurableObject
-from pyodide.ffi import to_js
 from urllib.parse import urlparse
 
+from pyodide.ffi import to_js
+from workers import DurableObject, Response, WorkerEntrypoint
+
 
 class List(DurableObject):
     async def get_messages(self):
@@ -12,7 +13,6 @@ async def add_message(self, message):
         messages = await self.get_messages()
         messages.append(message)
         await self.ctx.storage.put("messages", to_js(messages))
-        return
 
 
 class Default(WorkerEntrypoint):
diff --git a/08-cron/src/entry.py b/08-cron/src/entry.py
@@ -1,4 +1,4 @@
-from workers import WorkerEntrypoint, Response
+from workers import Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/09-workers-ai/src/entry.py b/09-workers-ai/src/entry.py
@@ -1,4 +1,4 @@
-from workers import WorkerEntrypoint, Response
+from workers import Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/10-workflows/src/entry.py b/10-workflows/src/entry.py
@@ -1,7 +1,8 @@
-from workers import WorkerEntrypoint, Response, WorkflowEntrypoint
-from urllib.parse import urlparse
 import asyncio
 import random
+from urllib.parse import urlparse
+
+from workers import Response, WorkerEntrypoint, WorkflowEntrypoint
 
 
 class DAGWorkflow(WorkflowEntrypoint):
diff --git a/13-js-api-pygments/py/src/entry.py b/13-js-api-pygments/py/src/entry.py
@@ -1,8 +1,8 @@
-from workers import WorkerEntrypoint, Response, Request
 from pygments import highlight
-from pygments.lexers import get_lexer_by_name, guess_lexer
 from pygments.formatters import HtmlFormatter
+from pygments.lexers import get_lexer_by_name, guess_lexer
 from pygments.util import ClassNotFound
+from workers import Request, Response, WorkerEntrypoint
 
 
 class Default(WorkerEntrypoint):
diff --git a/pyproject.toml b/pyproject.toml
@@ -13,3 +13,21 @@ dev = [
     "requests>=2.32.5",
     "ruff>=0.12.10",
 ]
+
+[tool.ruff]
+lint.select = [
+  "B0",     # bugbear (all B0* checks enabled by default)
+  "B904",   # bugbear (Within an except clause, raise exceptions with raise ... from err)
+  "B905",   # bugbear (zip() without an explicit strict= parameter set.)
+  "C4",     # flake8-comprehensions
+  "C9",     # mccabe complexity
+  "E",      # pycodestyles
+  "F",      # pyflakes
+  "I",      # isort
+  "PERF",   # Perflint
+  "PGH",    # pygrep-hooks
+  "PL",     # Pylint
+  "UP",     # pyupgrade
+  "W",      # pycodestyles
+]
+lint.ignore = ["PLR2004", "E501"]
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1,12 +1,12 @@
 import os
-import subprocess
-import time
 import socket
+import subprocess
 import sys
-import pytest
+import time
+from contextlib import contextmanager
 from pathlib import Path
 
-from contextlib import contextmanager
+import pytest
 
 REPO_ROOT = Path(__file__).parents[1]
 
diff --git a/tests/test_examples.py b/tests/test_examples.py
@@ -1,6 +1,7 @@
-import requests
-import pytest
 import subprocess
+
+import pytest
+import requests
 from conftest import REPO_ROOT
 
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-from workers import WorkerEntrypoint, Response`
	`1`	`+from workers import Response, WorkerEntrypoint`
`2`	`2`
`3`	`3`
`4`	`4`	`class Default(WorkerEntrypoint):`