Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Java 11 (OpenJDK 11) to the Codacy base Docker images, following the established pattern for Java version variants.
Changes:
- Added OpenJDK 11 JRE as a new available Java version option
- Updated documentation to list all four Java versions (8 default, 8 with OpenJ9, 11, and 17)
- Integrated Java 11 builds into all Makefile targets (build, scan, and push for both base and withtools images)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated documentation to list OpenJDK 11 JRE among available Java versions |
| Makefile | Added OPENJDK11_VERSION variable, BASE_IMAGE_OPENJDK11 base image definition, and integrated Java 11 builds into docker_build, docker_scan, and push-docker-image targets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhamborova
force-pushed
the
CY-7657_java11
branch
from
4d1130a to
fc2c4b3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
machadoit
left a comment
machadoit
left a comment
There was a problem hiding this comment.
Not sure if we are missing anything, what is here LGTM!
Makefile
Outdated
| docker_build: ## build the docker image | ||
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJDK) --no-cache -t $(BASE_IMAGE_NAME):$(VERSION) --target base . | ||
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJ9) --no-cache -t $(BASE_IMAGE_NAME):$(OPENJ9_VERSION) --target base . | ||
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJDK) --no-cache -t $(BASE_IMAGE_NAME):$(VERSION) --target base . |
Makefile
Outdated
|
|
||
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJDK) --no-cache -t $(WITHTOOLS_IMAGE_NAME):$(VERSION) --target withtools . | ||
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJ9) --no-cache -t $(WITHTOOLS_IMAGE_NAME):$(OPENJ9_VERSION) --target withtools . | ||
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJDK) --no-cache -t $(WITHTOOLS_IMAGE_NAME):$(VERSION) --target withtools . |
There was a problem hiding this comment.
Same here
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJDK) --no-cache -t $(WITHTOOLS_IMAGE_NAME):$(VERSION) --target withtools . | |
| docker build --build-arg base_image=$(BASE_IMAGE_OPENJDK) --no-cache -t $(WITHTOOLS_IMAGE_NAME):$(VERSION) --target withtools . |
lolgab
left a comment
lolgab
left a comment
There was a problem hiding this comment.
Commented about the alignment otherwise LGTM :)
No description provided.