Error handling fixes

Author: jeffyanta

ocp/rpc/transaction/swap_handler.go

@@ -774,12 +774,18 @@ func (h *ReserveCreateAndBuySwapHandler) MakeInstructions(ctx context.Context) (
 		h.buyer.PublicKey().ToBytes(),
 		common.CoreMintAccount.PublicKey().ToBytes(),
 	)
+	if err != nil {
+		return nil, err
+	}
 
 	createVmDepositAtaIxn, _, err := token.CreateAssociatedTokenAccountIdempotent(
 		h.destinationCurrencyAccounts.Authority.PublicKey().ToBytes(),
 		buyerVmDepositAccounts.Pda.PublicKey().ToBytes(),
 		h.destinationCurrencyAccounts.Mint.PublicKey().ToBytes(),
 	)
+	if err != nil {
+		return nil, err
+	}
 
 	closeTemporaryCoreMintAta := token.CloseAccount(
 		temporaryCoreMintAta,

ocp/worker/currency/launcher/util.go

@@ -495,6 +495,9 @@ func (p *runtime) initRemainingBlockchainAccounts(ctx context.Context, currencyM
 		common.GetSubsidizer().PublicKey().ToBytes(),
 		accounts.Mint.PublicKey().ToBytes(),
 	)
+	if err != nil {
+		return errors.Wrap(err, "error creating init fee ata ixn")
+	}
 
 	initAltIxn := address_lookup_table.Create(
 		accounts.Alt.PublicKey().ToBytes(),

ocp/worker/currency/launcher/worker.go

@@ -175,7 +175,7 @@ func (p *runtime) handleStateCompletingInitialization(ctx context.Context, curre
 		return errors.Wrap(err, "error checking if initialization phase 1 is complete")
 	} else if !ok {
 		// todo: How do we recover from this?
-		return errors.Wrap(err, "initialization phase 1 did not happen")
+		return errors.New("initialization phase 1 did not happen")
 	}
 
 	//
@@ -292,7 +292,7 @@ func (p *runtime) handleStateFinalValidation(ctx context.Context, currencyMetada
 	if err != nil {
 		return errors.Wrap(err, "error validating liquidity pool exists")
 	} else if !ok {
-		return errors.New("")
+		return errors.New("liquidity pool doesn't exist")
 	}
 
 	ok, err = validateVmExists(ctx, p.data, accounts.Vm)

ocp/worker/swap/util.go

@@ -194,7 +194,7 @@ func (p *runtime) maybeUpdateBalancesForFinalizedSwap(ctx context.Context, swapR
 
 			deltaQuarksOutOfVault, err := transaction_util.GetDeltaQuarksFromTokenBalances(currencyAccounts.VaultMint, tokenBalances)
 			if err != nil {
-				return 0, false, nil
+				return 0, false, err
 			}
 
 			if deltaQuarksOutOfVault >= 0 {