refactor: wip

Author: BioPhoton

packages/utils/src/lib/performance-observer.unit.test.ts

@@ -146,35 +146,6 @@ describe('PerformanceObserverSink', () => {
     );
   });
 
-  it('internal PerformanceObserver should observe buffered by default', () => {
-    const observer = new PerformanceObserverSink(options);
-
-    observer.subscribe();
-    expect(
-      MockPerformanceObserver.lastInstance()?.observe,
-    ).toHaveBeenCalledWith(
-      expect.objectContaining({
-        buffered: true,
-      }),
-    );
-  });
-
-  it('internal PerformanceObserver should observe buffered if buffered option is provided', () => {
-    const observer = new PerformanceObserverSink({
-      ...options,
-      captureBufferedEntries: true,
-    });
-
-    observer.subscribe();
-    expect(
-      MockPerformanceObserver.lastInstance()?.observe,
-    ).toHaveBeenCalledWith(
-      expect.objectContaining({
-        buffered: true,
-      }),
-    );
-  });
-
   it('internal PerformanceObserver should process observed entries', () => {
     const observer = new PerformanceObserverSink({
       ...options,

packages/utils/src/lib/profiler/profiler-node.unit.test.ts

@@ -107,6 +107,7 @@ const createSimpleProfiler = (
     prefix: 'cp',
     track: 'test-track',
     measureName: overrides?.measureName ?? 'simple',
+    enabled: overrides?.enabled ?? true,
     format: {
       encodePerfEntry: simpleEncoder,
       baseName: 'trace',
@@ -416,9 +417,14 @@ describe('NodejsProfiler', () => {
 
       const stats = profiler.stats;
       // shardPath uses dynamic shard ID format, so we check it matches the pattern
+      // Remove ^ and $ anchors from INSTANCE_ID pattern since we're embedding it
+      const instanceIdPattern = ID_PATTERNS.INSTANCE_ID.source.replace(
+        /^\^|\$$/g,
+        '',
+      );
       expect(stats.shardPath).toMatch(
         new RegExp(
-          `^tmp/profiles/stats-getter/trace\\.${ID_PATTERNS.INSTANCE_ID.source}\\.jsonl$`,
+          `^tmp/profiles/stats-getter/trace\\.${instanceIdPattern}\\.jsonl$`,
         ),
       );
       expect(stats).toStrictEqual({
@@ -589,7 +595,7 @@ describe('NodejsProfiler', () => {
       performance.clearMarks();
       profiler.setEnabled(true);
 
-      expectTransitionMarker('idle->running');
+      expectTransitionMarker('debug:idle->running');
     });
 
     it('should not create transition marker when transitioning from running to idle (profiler disabled)', () => {
@@ -626,10 +632,12 @@ describe('NodejsProfiler', () => {
       profiler.setEnabled(true);
 
       const marks = performance.getEntriesByType('mark');
-      const transitionMark = marks.find(mark => mark.name === 'idle->running');
+      const transitionMark = marks.find(
+        mark => mark.name === 'debug:idle->running',
+      );
       expect(transitionMark).toBeDefined();
 
-      expect(transitionMark?.name).toBe('idle->running');
+      expect(transitionMark?.name).toBe('debug:idle->running');
       expect(transitionMark?.detail).toBeDefined();
       const detail = transitionMark?.detail as UserTimingDetail;
       expect(detail.devtools).toBeDefined();

packages/utils/src/lib/profiler/profiler.unit.test.ts

@@ -49,6 +49,7 @@ describe('Profiler', () => {
 
   it('constructor should use defaults for measure', () => {
     const customProfiler = getProfiler({ color: 'secondary' });
+    customProfiler.setEnabled(true);
 
     const result = customProfiler.measure('test-operation', () => 'success');
 
@@ -148,6 +149,7 @@ describe('Profiler', () => {
 
   it('marker should execute without error when enabled', () => {
     const enabledProfiler = getProfiler();
+    enabledProfiler.setEnabled(true);
     expect(() => {
       enabledProfiler.marker('test-marker', {
         color: 'primary',
@@ -176,6 +178,7 @@ describe('Profiler', () => {
     performance.clearMarks();
 
     const profilerWithColor = getProfiler({ color: 'primary' });
+    profilerWithColor.setEnabled(true);
 
     expect(() => {
       profilerWithColor.marker('test-marker-default-color', {
@@ -200,6 +203,7 @@ describe('Profiler', () => {
 
   it('marker should execute without error when enabled with no default color', () => {
     const profilerNoColor = getProfiler();
+    profilerNoColor.setEnabled(true);
 
     expect(() => {
       profilerNoColor.marker('test-marker-no-color', {
@@ -244,6 +248,7 @@ describe('Profiler', () => {
     performance.clearMeasures();
 
     const enabledProfiler = getProfiler();
+    enabledProfiler.setEnabled(true);
     const workFn = vi.fn(() => 'result');
     const result = enabledProfiler.measure('test-event', workFn, {
       color: 'primary',
@@ -320,6 +325,7 @@ describe('Profiler', () => {
 
   it('measure should propagate errors when enabled and call error callback', () => {
     const enabledProfiler = getProfiler();
+    enabledProfiler.setEnabled(true);
     const error = new Error('Enabled test error');
     const workFn = vi.fn(() => {
       throw error;
@@ -358,6 +364,7 @@ describe('Profiler', () => {
 
   it('measureAsync should handle async operations correctly when enabled', async () => {
     const enabledProfiler = getProfiler();
+    enabledProfiler.setEnabled(true);
     const workFn = vi.fn(async () => {
       await Promise.resolve();
       return 'async-result';
@@ -430,6 +437,7 @@ describe('Profiler', () => {
 
   it('measureAsync should propagate async errors when enabled and call error callback', async () => {
     const enabledProfiler = getProfiler();
+    enabledProfiler.setEnabled(true);
     const error = new Error('Enabled async test error');
     const workFn = vi.fn(async () => {
       await Promise.resolve();