Skip to content

Commit 26aad73

Browse files
authored
refactor: drop rotation from Load3DCamera (Comfy-Org#14159)
1 parent bcf805a commit 26aad73

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

comfy_api/latest/_io.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -762,17 +762,17 @@ class AccumulationDict(TypedDict):
762762
@comfytype(io_type="LOAD3D_CAMERA")
763763
class Load3DCamera(ComfyTypeIO):
764764
class CameraInfo(TypedDict):
765-
position: dict[str, float | int]
766-
target: dict[str, float | int]
767-
zoom: int
768-
cameraType: str
769-
quaternion: NotRequired[dict[str, float | int]]
770-
rotation: NotRequired[dict[str, float | int | str]]
771-
fov: NotRequired[float | int]
772-
aspect: NotRequired[float | int]
773-
near: NotRequired[float | int]
774-
far: NotRequired[float | int]
775-
frustum: NotRequired[dict[str, float | int]]
765+
# Coordinate system: right-handed, Y-up, camera looks down -Z
766+
position: dict[str, float | int] # scene units
767+
target: dict[str, float | int] # scene units; OrbitControls focus point
768+
zoom: float | int # dimensionless, 1 = 100%
769+
cameraType: str # 'perspective' | 'orthographic'
770+
quaternion: NotRequired[dict[str, float | int]] # normalized, dimensionless; camera world rotation
771+
fov: NotRequired[float | int] # degrees, vertical FOV (perspective only)
772+
aspect: NotRequired[float | int] # width / height (perspective only)
773+
near: NotRequired[float | int] # scene units
774+
far: NotRequired[float | int] # scene units
775+
frustum: NotRequired[dict[str, float | int]] # orthographic only: {left, right, top, bottom} in scene units
776776

777777
Type = CameraInfo
778778

0 commit comments

Comments
 (0)